-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INFRA] Parallelize the Buildkite test
job on PR
#7197
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
1d24b58
Refactoring test Bash script for parallelization.
1Copenut f5442c7
Splitting test tasks linting and unit testing.
1Copenut 69fd82c
Moved agents declaration into individual steps.
1Copenut 2fb5747
Was missing the double ampersand to run Yarn commands.
1Copenut 0902f9a
Restoring Cypress install to all commands.
1Copenut 7967c91
Adjusting conditional array adds to be one string each.
1Copenut 3c4493c
Removed double quote literals for bash -c command.
1Copenut 4d04d63
Updating all bash strings after successful lint run. Adding one Cypre…
1Copenut d2a29f4
Adding Cypress runs for React 16 and 17.
1Copenut 2818174
Refactoring test pipeline to switch case for readability.
1Copenut 779c584
Labeling steps for task recognition.
1Copenut 09fe4e8
Updating comment about branch filter.
1Copenut File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,44 @@ | ||
# 🏠/.buildkite/pipelines/pipeline_pull_request_test.yml | ||
|
||
steps: | ||
- agents: | ||
- command: .buildkite/scripts/pipeline_test.sh | ||
label: ":typescript: Linting" | ||
agents: | ||
provider: "gcp" | ||
command: .buildkite/scripts/pipeline_test.sh | ||
if: build.branch != "main" # We're skipping testing commits in main for now to maintain parity with previous Jenkins setup | ||
env: | ||
TEST_TYPE: 'lint' | ||
if: build.branch != "main" # This job is triggered by the combined test and deploy docs for every PR | ||
- command: .buildkite/scripts/pipeline_test.sh | ||
label: ":jest: Unit tests" | ||
agents: | ||
provider: "gcp" | ||
env: | ||
TEST_TYPE: 'unit' | ||
if: build.branch != "main" | ||
- command: .buildkite/scripts/pipeline_test.sh | ||
label: ":cypress: Cypress tests on React 16" | ||
agents: | ||
provider: "gcp" | ||
env: | ||
TEST_TYPE: 'cypress:16' | ||
if: build.branch != "main" | ||
artifact_paths: | ||
- "cypress/react16/screenshots/**/*.png" | ||
- command: .buildkite/scripts/pipeline_test.sh | ||
label: ":cypress: Cypress tests on React 17" | ||
agents: | ||
provider: "gcp" | ||
env: | ||
TEST_TYPE: 'cypress:17' | ||
if: build.branch != "main" | ||
artifact_paths: | ||
- "cypress/react17/screenshots/**/*.png" | ||
- command: .buildkite/scripts/pipeline_test.sh | ||
label: ":cypress: Cypress tests on React 18" | ||
agents: | ||
provider: "gcp" | ||
env: | ||
TEST_TYPE: 'cypress:18' | ||
if: build.branch != "main" | ||
artifact_paths: | ||
- "cypress/screenshots/**/*.png" | ||
- "cypress/react18/screenshots/**/*.png" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Originally I used
if / elif / fi
blocks but it was getting hard to read. This felt cleaner and more scalable.