Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wiki] RTL docs update #7199

Merged
merged 1 commit into from
Sep 19, 2023
Merged

[wiki] RTL docs update #7199

merged 1 commit into from
Sep 19, 2023

Conversation

cee-chen
Copy link
Contributor

Summary

Follow up to #7111 (comment)

We discussed as a team using screen from RTL vs destructuring queries from render, and in general decided to clearly document that we prefer render for the EUI codebase.

QA

General checklist

N/A, wiki only

@cee-chen cee-chen added documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog labels Sep 19, 2023
@cee-chen cee-chen requested a review from a team September 19, 2023 18:23
@cee-chen cee-chen mentioned this pull request Sep 19, 2023
Merged
9 tasks
1Copenut
1Copenut approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@1Copenut 1Copenut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!

@cee-chen cee-chen merged commit ca5bf9a into elastic:main Sep 19, 2023
6 checks passed
@cee-chen cee-chen deleted the wiki/rtl branch September 19, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1Copenut 1Copenut 1Copenut approved these changes

Assignees
No one assigned
Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cee-chen @1Copenut