Adding a CODEOWNERS for eui-team to improve merge security. #7200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cee-chen
reviewed
Sep 19, 2023
cee-chen
reviewed
Sep 19, 2023
Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com>
|
Buildkite test this |
|
Preview staging links for this PR:
|
💚 Build Succeeded
History
cc @1Copenut |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding a
CODEOWNERSfile to the root of EUI. This file will be paired with a protected branch rule onmainafter it's merged. The file is meant to improve our existing security posture of having at least one member of the EUI team review and approve code before merging tomain.We do this implicitly, this change just makes it explicit and verifiable.
QA
QA will be done manually. After the file is approved, Trevor will enable the branch rule and test with a quick docs PR.