Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiPopover][EuiInputPopover] Misc fixes and CSS cleanup #7211

Merged
merged 11 commits into from
Sep 22, 2023
Merged

[EuiPopover][EuiInputPopover] Misc fixes and CSS cleanup #7211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
2874622
DRY out transition/animation CSS
cee-chen Sep 21, 2023
fb8749a
[misc] DRY out `translateDistance`
cee-chen Sep 21, 2023
21cb032
Fix missing popover shadows on attached popovers
cee-chen Sep 21, 2023
d94dcd8
Fix missing transition on popover close
cee-chen Sep 21, 2023
8b042b0
Clean up unnecessary CSS overrides
cee-chen Sep 21, 2023
fc1ced6
[misc nit] move unnecessary definition/destructure
cee-chen Sep 21, 2023
b5cd3c7
Fix EuiInputPopover offset
cee-chen Sep 21, 2023
65e5ea0
Fix attached popovers to not cross axes when space is insufficient
cee-chen Sep 21, 2023
d5ccb72
Update downstream popover snapshots
cee-chen Sep 21, 2023
1449880
changelog
cee-chen Sep 21, 2023
4420a7a
[EuiPopover] Add new configurable `repositionToCrossAxis` prop
cee-chen Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/basic_table/__snapshots__/collapsed_item_actions.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ exports[`CollapsedItemActions render with href and _target provided 1`] = `
ownFocus={true}
panelPaddingSize="none"
popoverRef={[Function]}
repositionToCrossAxis={true}
>
<EuiContextMenuPanel
items={
Expand Down
2 changes: 1 addition & 1 deletion src/components/breadcrumbs/__snapshots__/breadcrumb.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ exports[`EuiBreadcrumbContent renders breadcrumbs with \`popoverContent\` with p
aria-describedby="generated-id"
aria-live="off"
aria-modal="true"
class="euiPanel euiPanel--plain euiPanel--paddingMedium euiPopover__panel emotion-euiPanel-grow-m-m-plain-euiPopover__panel-isOpen-bottom"
class="euiPanel euiPanel--plain euiPanel--paddingMedium euiPopover__panel emotion-euiPanel-grow-m-m-plain-euiPopover__panel-isOpen-hasTransform-bottom"
data-autofocus="true"
data-popover-open="true"
data-popover-panel="true"
Expand Down
2 changes: 1 addition & 1 deletion src/components/code/__snapshots__/code_block_annotations.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ exports[`EuiCodeBlockAnnotation renders 1`] = `
aria-label="aria-label"
aria-live="off"
aria-modal="true"
class="euiPanel euiPanel--plain euiPanel--paddingMedium euiPopover__panel emotion-euiPanel-grow-m-m-plain-euiPopover__panel-isOpen-bottom"
class="euiPanel euiPanel--plain euiPanel--paddingMedium euiPopover__panel emotion-euiPanel-grow-m-m-plain-euiPopover__panel-isOpen-hasTransform-bottom"
data-autofocus="true"
data-popover-open="true"
data-popover-panel="true"
Expand Down
2 changes: 1 addition & 1 deletion ...nav_beta/collapsible_nav_item/collapsed/__snapshots__/collapsed_nav_popover.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ exports[`EuiCollapsedNavPopover renders the title and sub-items within the popov
aria-label="aria-label"
aria-live="off"
aria-modal="true"
class="euiPanel euiPanel--plain euiPopover__panel emotion-euiPanel-grow-m-plain-euiPopover__panel-isOpen-right-euiCollapsedNavPopover__panel"
class="euiPanel euiPanel--plain euiPopover__panel emotion-euiPanel-grow-m-plain-euiPopover__panel-isOpen-hasTransform-right-euiCollapsedNavPopover__panel"
data-autofocus="true"
data-popover-open="true"
data-popover-panel="true"
Expand Down
4 changes: 2 additions & 2 deletions src/components/combo_box/__snapshots__/combo_box.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,7 +522,7 @@ exports[`props option.prepend & option.append renders in single selection 1`] =

exports[`props option.prepend & option.append renders in the options dropdown 1`] = `
<div
class="euiPanel euiPanel--plain euiPopover__panel euiComboBoxOptionsList emotion-euiPanel-grow-m-plain-euiPopover__panel-isOpen-bottom-isOpen-bottom"
class="euiPanel euiPanel--plain euiPopover__panel euiComboBoxOptionsList emotion-euiPanel-grow-m-plain-euiPopover__panel-isOpen-isAttached-bottom"
data-popover-open="true"
data-popover-panel="true"
data-test-subj="comboBoxOptionsList"
Expand Down Expand Up @@ -703,7 +703,7 @@ exports[`props options list is rendered 1`] = `
</div>
</div>
<div
class="euiPanel euiPanel--plain euiPopover__panel euiComboBoxOptionsList emotion-euiPanel-grow-m-plain-euiPopover__panel-isOpen-bottom-isOpen-bottom"
class="euiPanel euiPanel--plain euiPopover__panel euiComboBoxOptionsList emotion-euiPanel-grow-m-plain-euiPopover__panel-isOpen-isAttached-bottom"
data-popover-open="true"
data-popover-panel="true"
data-test-subj="comboBoxOptionsList alsoGetsAppliedToOptionsList-optionsList"
Expand Down
1 change: 1 addition & 0 deletions src/components/datagrid/body/header/__snapshots__/data_grid_header_cell.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ exports[`EuiDataGridHeaderCell renders 1`] = `
token="euiDataGridHeaderCell.actionsPopoverScreenReaderText"
/>
}
repositionToCrossAxis={true}
>
<EuiListGroup
data-test-subj="dataGridHeaderCellActionGroup-someColumn"
Expand Down
1 change: 1 addition & 0 deletions src/components/datagrid/controls/__snapshots__/display_selector.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ exports[`useDataGridDisplaySelector displaySelector renders a toolbar button/pop
ownFocus={true}
panelClassName="euiDataGrid__displayPopoverPanel"
panelPaddingSize="s"
repositionToCrossAxis={true}
>
<EuiI18n
defaults={
Expand Down
2 changes: 1 addition & 1 deletion src/components/datagrid/controls/__snapshots__/keyboard_shortcuts.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ exports[`useDataGridKeyboardShortcuts returns a popover containing a list of key
aria-describedby="generated-id"
aria-live="off"
aria-modal="true"
class="euiPanel euiPanel--plain euiPanel--paddingMedium euiPopover__panel emotion-euiPanel-grow-m-m-plain-euiPopover__panel-isOpen-bottom"
class="euiPanel euiPanel--plain euiPanel--paddingMedium euiPopover__panel emotion-euiPanel-grow-m-m-plain-euiPopover__panel-isOpen-hasTransform-bottom"
data-autofocus="true"
data-popover-open="true"
data-popover-panel="true"
Expand Down
4 changes: 2 additions & 2 deletions src/components/form/range/__snapshots__/range.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,11 +461,11 @@ exports[`EuiRange props slider should display in popover 1`] = `
aria-describedby="generated-id"
aria-live="assertive"
aria-modal="true"
class="euiPanel euiPanel--plain euiPanel--paddingSmall euiPopover__panel emotion-euiPanel-grow-m-s-plain-euiPopover__panel-bottom"
class="euiPanel euiPanel--plain euiPanel--paddingSmall euiPopover__panel emotion-euiPanel-grow-m-s-plain-euiPopover__panel-isAttached-bottom"
data-popover-panel="true"
data-test-subj="test"
role="dialog"
style="top: 8px; left: -22px; will-change: transform, opacity; z-index: 2000;"
style="top: 0px; left: -22px; will-change: transform, opacity; z-index: 2000;"
>
<p
class="emotion-euiScreenReaderOnly"
Expand Down
16 changes: 8 additions & 8 deletions src/components/form/super_select/__snapshots__/super_select.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,10 +142,10 @@ exports[`EuiSuperSelect props custom display is propagated to dropdown 1`] = `
<div
aria-live="assertive"
aria-modal="true"
class="euiPanel euiPanel--plain euiPopover__panel emotion-euiPanel-grow-m-plain-euiPopover__panel-bottom"
class="euiPanel euiPanel--plain euiPopover__panel emotion-euiPanel-grow-m-plain-euiPopover__panel-isAttached-bottom"
data-popover-panel="true"
role="dialog"
style="top: 8px; left: -22px; will-change: transform, opacity; z-index: 2000;"
style="top: 0px; left: -22px; will-change: transform, opacity; z-index: 2000;"
>
<div>
<div
Expand Down Expand Up @@ -387,10 +387,10 @@ exports[`EuiSuperSelect props more props are propogated to each option 1`] = `
<div
aria-live="assertive"
aria-modal="true"
class="euiPanel euiPanel--plain euiPopover__panel emotion-euiPanel-grow-m-plain-euiPopover__panel-bottom"
class="euiPanel euiPanel--plain euiPopover__panel emotion-euiPanel-grow-m-plain-euiPopover__panel-isAttached-bottom"
data-popover-panel="true"
role="dialog"
style="top: 8px; left: -22px; will-change: transform, opacity; z-index: 2000;"
style="top: 0px; left: -22px; will-change: transform, opacity; z-index: 2000;"
>
<div>
<div
Expand Down Expand Up @@ -533,10 +533,10 @@ exports[`EuiSuperSelect props options are rendered when select is open 1`] = `
<div
aria-live="assertive"
aria-modal="true"
class="euiPanel euiPanel--plain euiPopover__panel emotion-euiPanel-grow-m-plain-euiPopover__panel-bottom"
class="euiPanel euiPanel--plain euiPopover__panel emotion-euiPanel-grow-m-plain-euiPopover__panel-isAttached-bottom"
data-popover-panel="true"
role="dialog"
style="top: 8px; left: -22px; will-change: transform, opacity; z-index: 2000;"
style="top: 0px; left: -22px; will-change: transform, opacity; z-index: 2000;"
>
<div>
<div
Expand Down Expand Up @@ -678,10 +678,10 @@ exports[`EuiSuperSelect props renders popoverProps on the underlying EuiPopover
<div
aria-live="assertive"
aria-modal="true"
class="euiPanel euiPanel--plain euiPopover__panel goes-on-popover-panel emotion-euiPanel-grow-m-plain-euiPopover__panel-bottom"
class="euiPanel euiPanel--plain euiPopover__panel goes-on-popover-panel emotion-euiPanel-grow-m-plain-euiPopover__panel-isAttached-bottom"
data-popover-panel="true"
role="dialog"
style="top: 8px; left: -22px; will-change: transform, opacity; z-index: 2000;"
style="top: 0px; left: -22px; will-change: transform, opacity; z-index: 2000;"
>
<div>
<div
Expand Down
2 changes: 1 addition & 1 deletion src/components/popover/__snapshots__/popover.rtl.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ exports[`EuiPopover snapshot testing renders with popover contents 1`] = `
aria-label="aria-label"
aria-live="off"
aria-modal="true"
class="euiPanel euiPanel--plain euiPanel--paddingMedium euiPopover__panel emotion-euiPanel-grow-m-m-plain-euiPopover__panel-isOpen-bottom"
class="euiPanel euiPanel--plain euiPanel--paddingMedium euiPopover__panel emotion-euiPanel-grow-m-m-plain-euiPopover__panel-isOpen-hasTransform-bottom"
data-autofocus="true"
data-popover-open="true"
data-popover-panel="true"
Expand Down
133 changes: 15 additions & 118 deletions src/components/popover/__snapshots__/popover.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ exports[`EuiPopover props arrowChildren is rendered 1`] = `
<div>
<div
class="euiPopover euiPopover-isOpen emotion-euiPopover"
id="19"
id="20"
>
<div
class="euiPopover__anchor css-16vtueo-render"
Expand All @@ -102,7 +102,7 @@ exports[`EuiPopover props arrowChildren is rendered 1`] = `
aria-describedby="generated-id"
aria-live="off"
aria-modal="true"
class="euiPanel euiPanel--plain euiPanel--paddingMedium euiPopover__panel emotion-euiPanel-grow-m-m-plain-euiPopover__panel-isOpen-bottom"
class="euiPanel euiPanel--plain euiPanel--paddingMedium euiPopover__panel emotion-euiPanel-grow-m-m-plain-euiPopover__panel-isOpen-hasTransform-bottom"
data-autofocus="true"
data-popover-open="true"
data-popover-panel="true"
Expand Down Expand Up @@ -139,7 +139,7 @@ exports[`EuiPopover props buffer 1`] = `
<div>
<div
class="euiPopover euiPopover-isOpen emotion-euiPopover"
id="20"
id="21"
>
<div
class="euiPopover__anchor css-16vtueo-render"
Expand All @@ -158,7 +158,7 @@ exports[`EuiPopover props buffer 1`] = `
aria-describedby="generated-id"
aria-live="off"
aria-modal="true"
class="euiPanel euiPanel--plain euiPanel--paddingMedium euiPopover__panel emotion-euiPanel-grow-m-m-plain-euiPopover__panel-isOpen-bottom"
class="euiPanel euiPanel--plain euiPanel--paddingMedium euiPopover__panel emotion-euiPanel-grow-m-m-plain-euiPopover__panel-isOpen-hasTransform-bottom"
data-autofocus="true"
data-popover-open="true"
data-popover-panel="true"
Expand Down Expand Up @@ -193,7 +193,7 @@ exports[`EuiPopover props buffer for all sides 1`] = `
<div>
<div
class="euiPopover euiPopover-isOpen emotion-euiPopover"
id="21"
id="22"
>
<div
class="euiPopover__anchor css-16vtueo-render"
Expand All @@ -212,7 +212,7 @@ exports[`EuiPopover props buffer for all sides 1`] = `
aria-describedby="generated-id"
aria-live="off"
aria-modal="true"
class="euiPanel euiPanel--plain euiPanel--paddingMedium euiPopover__panel emotion-euiPanel-grow-m-m-plain-euiPopover__panel-isOpen-bottom"
class="euiPanel euiPanel--plain euiPanel--paddingMedium euiPopover__panel emotion-euiPanel-grow-m-m-plain-euiPopover__panel-isOpen-hasTransform-bottom"
data-autofocus="true"
data-popover-open="true"
data-popover-panel="true"
Expand Down Expand Up @@ -279,7 +279,7 @@ exports[`EuiPopover props focusTrapProps is rendered 1`] = `
aria-describedby="generated-id"
aria-live="off"
aria-modal="true"
class="euiPanel euiPanel--plain euiPanel--paddingMedium euiPopover__panel emotion-euiPanel-grow-m-m-plain-euiPopover__panel-isOpen-bottom"
class="euiPanel euiPanel--plain euiPanel--paddingMedium euiPopover__panel emotion-euiPanel-grow-m-m-plain-euiPopover__panel-isOpen-hasTransform-bottom"
data-autofocus="true"
data-popover-open="true"
data-popover-panel="true"
Expand Down Expand Up @@ -346,7 +346,7 @@ exports[`EuiPopover props isOpen renders true 1`] = `
aria-describedby="generated-id"
aria-live="off"
aria-modal="true"
class="euiPanel euiPanel--plain euiPanel--paddingMedium euiPopover__panel emotion-euiPanel-grow-m-m-plain-euiPopover__panel-isOpen-bottom"
class="euiPanel euiPanel--plain euiPanel--paddingMedium euiPopover__panel emotion-euiPanel-grow-m-m-plain-euiPopover__panel-isOpen-hasTransform-bottom"
data-autofocus="true"
data-popover-open="true"
data-popover-panel="true"
Expand Down Expand Up @@ -377,109 +377,6 @@ exports[`EuiPopover props isOpen renders true 1`] = `
</div>
`;

exports[`EuiPopover props offset with arrow 1`] = `
<div>
<div
class="euiPopover euiPopover-isOpen emotion-euiPopover"
id="17"
>
<div
class="euiPopover__anchor css-16vtueo-render"
>
<button />
</div>
<div
data-focus-guard="true"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="-1"
/>
<div
data-focus-lock-disabled="disabled"
>
<div
aria-describedby="generated-id"
aria-live="off"
aria-modal="true"
class="euiPanel euiPanel--plain euiPanel--paddingMedium euiPopover__panel emotion-euiPanel-grow-m-m-plain-euiPopover__panel-isOpen-bottom"
data-autofocus="true"
data-popover-open="true"
data-popover-panel="true"
role="dialog"
style="top: 26px; left: -22px; will-change: transform, opacity; z-index: 2000;"
tabindex="0"
>
<div
class="euiPopover__arrow emotion-euiPopoverArrow-bottom"
data-popover-arrow="bottom"
style="left: 10px; top: 0px;"
/>
<p
class="emotion-euiScreenReaderOnly"
id="generated-id"
>
You are in a dialog. Press Escape, or tap/click outside the dialog to close.
</p>
<div />
</div>
</div>
<div
data-focus-guard="true"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="-1"
/>
</div>
</div>
`;

exports[`EuiPopover props offset without arrow 1`] = `
<div>
<div
class="euiPopover euiPopover-isOpen emotion-euiPopover"
id="18"
>
<div
class="euiPopover__anchor css-16vtueo-render"
>
<button />
</div>
<div
data-focus-guard="true"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="-1"
/>
<div
data-focus-lock-disabled="disabled"
>
<div
aria-describedby="generated-id"
aria-live="off"
aria-modal="true"
class="euiPanel euiPanel--plain euiPanel--paddingMedium euiPopover__panel emotion-euiPanel-grow-m-m-plain-euiPopover__panel-isOpen-bottom"
data-autofocus="true"
data-popover-open="true"
data-popover-panel="true"
role="dialog"
style="top: 18px; left: -22px; will-change: transform, opacity; z-index: 2000;"
tabindex="0"
>
<p
class="emotion-euiScreenReaderOnly"
id="generated-id"
>
You are in a dialog. Press Escape, or tap/click outside the dialog to close.
</p>
<div />
</div>
</div>
<div
data-focus-guard="true"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="-1"
/>
</div>
</div>
`;

exports[`EuiPopover props ownFocus defaults to true 1`] = `
<div>
<div
Expand All @@ -503,7 +400,7 @@ exports[`EuiPopover props ownFocus defaults to true 1`] = `
aria-describedby="generated-id"
aria-live="off"
aria-modal="true"
class="euiPanel euiPanel--plain euiPanel--paddingMedium euiPopover__panel emotion-euiPanel-grow-m-m-plain-euiPopover__panel-isOpen-bottom"
class="euiPanel euiPanel--plain euiPanel--paddingMedium euiPopover__panel emotion-euiPanel-grow-m-m-plain-euiPopover__panel-isOpen-hasTransform-bottom"
data-autofocus="true"
data-popover-open="true"
data-popover-panel="true"
Expand Down Expand Up @@ -556,7 +453,7 @@ exports[`EuiPopover props ownFocus renders false 1`] = `
<div
aria-live="assertive"
aria-modal="true"
class="euiPanel euiPanel--plain euiPanel--paddingMedium euiPopover__panel emotion-euiPanel-grow-m-m-plain-euiPopover__panel-isOpen-bottom"
class="euiPanel euiPanel--plain euiPanel--paddingMedium euiPopover__panel emotion-euiPanel-grow-m-m-plain-euiPopover__panel-isOpen-hasTransform-bottom"
data-popover-open="true"
data-popover-panel="true"
role="dialog"
Expand Down Expand Up @@ -602,7 +499,7 @@ exports[`EuiPopover props panelClassName is rendered 1`] = `
aria-describedby="generated-id"
aria-live="off"
aria-modal="true"
class="euiPanel euiPanel--plain euiPanel--paddingMedium euiPopover__panel test emotion-euiPanel-grow-m-m-plain-euiPopover__panel-isOpen-bottom"
class="euiPanel euiPanel--plain euiPanel--paddingMedium euiPopover__panel test emotion-euiPanel-grow-m-m-plain-euiPopover__panel-isOpen-hasTransform-bottom"
data-autofocus="true"
data-popover-open="true"
data-popover-panel="true"
Expand Down Expand Up @@ -656,7 +553,7 @@ exports[`EuiPopover props panelPaddingSize is rendered 1`] = `
aria-describedby="generated-id"
aria-live="off"
aria-modal="true"
class="euiPanel euiPanel--plain euiPanel--paddingSmall euiPopover__panel emotion-euiPanel-grow-m-s-plain-euiPopover__panel-isOpen-bottom"
class="euiPanel euiPanel--plain euiPanel--paddingSmall euiPopover__panel emotion-euiPanel-grow-m-s-plain-euiPopover__panel-isOpen-hasTransform-bottom"
data-autofocus="true"
data-popover-open="true"
data-popover-panel="true"
Expand Down Expand Up @@ -710,7 +607,7 @@ exports[`EuiPopover props panelProps is rendered 1`] = `
aria-describedby="generated-id"
aria-live="off"
aria-modal="true"
class="euiPanel euiPanel--plain euiPanel--paddingMedium euiPopover__panel testClass1 testClass2 emotion-euiPanel-grow-m-m-plain-euiPopover__panel-isOpen-bottom-euiTestCss"
class="euiPanel euiPanel--plain euiPanel--paddingMedium euiPopover__panel testClass1 testClass2 emotion-euiPanel-grow-m-m-plain-euiPopover__panel-isOpen-hasTransform-bottom-euiTestCss"
data-autofocus="true"
data-popover-open="true"
data-popover-panel="true"
Expand Down Expand Up @@ -746,7 +643,7 @@ exports[`EuiPopover props popoverScreenReaderText 1`] = `
<div>
<div
class="euiPopover euiPopover-isOpen emotion-euiPopover"
id="22"
id="23"
>
<div
class="euiPopover__anchor css-16vtueo-render"
Expand All @@ -765,7 +662,7 @@ exports[`EuiPopover props popoverScreenReaderText 1`] = `
aria-describedby="generated-id"
aria-live="assertive"
aria-modal="true"
class="euiPanel euiPanel--plain euiPanel--paddingMedium euiPopover__panel emotion-euiPanel-grow-m-m-plain-euiPopover__panel-isOpen-bottom"
class="euiPanel euiPanel--plain euiPanel--paddingMedium euiPopover__panel emotion-euiPanel-grow-m-m-plain-euiPopover__panel-isOpen-hasTransform-bottom"
data-popover-open="true"
data-popover-panel="true"
role="dialog"
Expand Down
Loading
Loading