Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating docs link and description in release process doc. #7225

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Updating docs link and description in release process doc. #7225

merged 2 commits into from
Sep 25, 2023

Conversation

1Copenut
Copy link
Contributor

@1Copenut 1Copenut commented Sep 25, 2023

Summary

This PR updates the Release process wiki doc to remove references to GitHub pages and accurately describe the release docs build process.

QA

Remove or strikethrough items that do not apply to your PR.

General checklist

  • Browser QA
    • Checked in mobile
    • Checked in Chrome, Safari, Edge, and Firefox
  • Docs site QA

@1Copenut 1Copenut added documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog labels Sep 25, 2023
@1Copenut 1Copenut requested a review from a team as a code owner September 25, 2023 20:01
@1Copenut 1Copenut self-assigned this Sep 25, 2023
Copy link
Contributor

@cee-chen cee-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh man, I totally forgot about docs! Thanks for grabbing this Trevor, you rock!

Can you also grab the following text:

The latest changes have now been pushed to GitHub, a new `git` tag now exists on GitHub, the new release can be installed from `npm`, and the [documentation site][docs] will update momentarily<sup>\*</sup>.

<sup>_\* GitHub Pages sites are cached aggressively and can sometimes take a couple of minutes to update._</sup>

->

The latest changes have now been pushed to GitHub, a new `git` tag now exists on GitHub, the new release can be installed from `npm`, and the [documentation site][docs] will update momentarily.

Copy link
Contributor

@cee-chen cee-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@1Copenut 1Copenut merged commit b38001b into elastic:main Sep 25, 2023
1 check passed
@1Copenut 1Copenut deleted the docs/eui-release-process branch September 25, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants