Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deps] Remove prop-types as peer/dev dependency, update version to match Kibana #7602

Merged
merged 4 commits into from
Mar 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions changelogs/upcoming/7602.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
**Dependency updates**

- Updated `prop-types` to v15.18.1
- Removed `prop-types` as a peer depedency, per package recommendation
4 changes: 1 addition & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
"lodash": "^4.17.21",
"mdast-util-to-hast": "^10.2.0",
"numeral": "^2.0.6",
"prop-types": "^15.6.0",
"prop-types": "^15.8.1",
"react-dropzone": "^11.7.1",
"react-element-to-jsx-string": "^15.0.0",
"react-focus-on": "^3.9.1",
Expand Down Expand Up @@ -212,7 +212,6 @@
"pre-push": "^0.1.4",
"prettier": "^2.8.8",
"process": "^0.11.10",
"prop-types": "^15.6.0",
"raw-loader": "^4.0.1",
"react": "^18.2.0",
"react-16": "npm:react@^16.14.0",
Expand Down Expand Up @@ -257,7 +256,6 @@
"@types/react": "^16.9 || ^17.0 || ^18.0",
"@types/react-dom": "^16.9 || ^17.0 || ^18.0",
"moment": "^2.13.0",
"prop-types": "^15.5.0",
"react": "^16.12 || ^17.0 || ^18.0",
"react-dom": "^16.12 || ^17.0 || ^18.0",
"typescript": "~4.5.3"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export const GettingStarted = {
<EuiSpacer />
<EuiCodeBlock language="bash" isCopyable fontSize="m">
{
'yarn add @elastic/eui @elastic/datemath @emotion/react @emotion/css moment prop-types'
'yarn add @elastic/eui @elastic/datemath @emotion/react @emotion/css moment'
}
</EuiCodeBlock>
<EuiSpacer />
Expand Down
2 changes: 1 addition & 1 deletion wiki/consuming-eui/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ yarn add @elastic/eui
Note that EUI has [several `peerDependencies` requirements](../../package.json) that will also need to be installed if starting with a blank project.

```bash
yarn add @elastic/eui @elastic/datemath @emotion/react @emotion/css moment prop-types
yarn add @elastic/eui @elastic/datemath @emotion/react @emotion/css moment
```

## Requirements and dependencies
Expand Down
2 changes: 1 addition & 1 deletion yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -17823,7 +17823,7 @@ prop-types-exact@^1.2.0:
object.assign "^4.1.0"
reflect.ownkeys "^0.2.0"

prop-types@^15.6.0, prop-types@^15.6.2, prop-types@^15.7.0, prop-types@^15.7.2, prop-types@^15.8.1:
prop-types@^15.6.2, prop-types@^15.7.0, prop-types@^15.7.2, prop-types@^15.8.1:
version "15.8.1"
resolved "https://registry.yarnpkg.com/prop-types/-/prop-types-15.8.1.tgz#67d87bf1a694f48435cf332c24af10214a3140b5"
integrity sha512-oj87CgZICdulUohogVAR7AjlC0327U4el4L6eAvOqCeudMDVU0NThNaV+b9Df4dXgSP1gXMTnPdhfe/2qDH5cg==
Expand Down
Loading