[EuiDatagrid] fix content header styles to ensure text alignment is applied #7720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgadewoll
added
bug
documentation
cee-chen
reviewed
Apr 30, 2024
cee-chen
reviewed
Apr 30, 2024
There was a problem hiding this comment.
me initially seeing the 300+ line diff on this PR: panik
me seeing it's a storybook story: kalm
In all seriousness thanks for going the extra mile to add a storybook for EuiDataGrid! 🙌
cee-chen
reviewed
Apr 30, 2024
cee-chen
approved these changes
May 2, 2024
|
Preview staging links for this PR:
|
💚 Build Succeeded
History
|
mgadewoll
added a commit
to mgadewoll/eui
that referenced
this pull request
May 3, 2024
jbudz
pushed a commit
to elastic/kibana
that referenced
this pull request
May 10, 2024
`v94.2.1-backport.0` ⏩ `v94.3.0` _[Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_ --- ## [`v94.3.0`](https://github.com/elastic/eui/releases/v94.3.0) - Updated `launch` glyph for `EuiIcon` ([#7670](elastic/eui#7670)) - Updated `EuiComboBox`'s `options` to support including tooltip details for selectable options. Use `toolTipContent` to render tooltip information, and `toolTipProps` to optionally customize the tooltip rendering behavior ([#7700](elastic/eui#7700)) - Updated the following existing glyphs in `EuiIcon`: ([#7727](elastic/eui#7727)) - `error` (now an outlined version instead of filled) - `tokenMetricCounter` - `tokenMetricGauge` - Added the following new glyphs to `EuiIcon`: ([#7727](elastic/eui#7727)) - `tokenDimension` - `clickLeft` - `clickRight` - `clockCounter` - `errorFilled` (the previous `error` glyph design) - `warningFilled` **Bug fixes** - Fixed a visual layout bug for `EuiComboBox` with `isLoading` in mobile views ([#7700](elastic/eui#7700)) - Fixed missing styles on header cells of `EuiDataGrid` that prevented content text alignment styles to apply ([#7720](elastic/eui#7720)) - Fixed `EuiFlexGroup` and `EuiFlexItem` `ref` prop typing to support refs of the same type as the passed `component` type and allow `displayName` to be defined for easy component naming when using component wrappers like `styled()` ([#7724](elastic/eui#7724)) --- Most of the code changes you'll see in this PR are caused by the recent EuiFlex* changes making it generic. This, unfortunately, is something that `styled()` doesn't always like. I replaced the failing usages of `styled(EuiFlexGroup)` and `styled(EuiFlexItem)` to use `component` and other native EuiFlex* props, resulting in the same output but being better typed. We plan to add more props to EuiFlex* components giving developers control over properties like `flex-grow` and `flex-shring`, and reducing the need for writing any custom CSS when using these components. This should reduce the number of `styled()` wrappers needed even further --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #7669
This PR adds styles back to
.euiDataGridHeaderCell__contentthat were removed previously in this PR.These styles ensure the header content is stretched and allows for its content to properly apply its own text styles.
Additionally this PR adds a
Playgroundstory forEuiDataGridfor easier testing.after
QA
ensure custom text alignment styles are applied
gh pr checkout 7720src-docs/src/views/datagrid/basics/datagrid.jsand update a column to use a customdisplayvalue, e.g.:http://localhost:8030/#/tabular-content/data-grid#core-conceptsand confirm the changed column header now is right alignedreview the added
EuiDataGridstory and its controls that they are useable and usefulGeneral checklist
Checked in both light and dark modesChecked for accessibility including keyboard-only and screenreader modesIf applicable, added the breaking change issue label (and filled out the breaking change checklist)