Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensuring switches’ inputs are still hidden when [disabled]. #778

Merged
merged 3 commits into from
May 7, 2018
Merged

Ensuring switches’ inputs are still hidden when [disabled]. #778

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
28d110d
Ensuring switches’ inputs it's still hidden when [disabled].
May 4, 2018
3312acf
changelog
May 4, 2018
77e3182
Merge branch 'master' into fix-disabled-switch
cchaos May 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
## [`master`](https://github.com/elastic/eui/tree/master)

No public interface changes since `0.0.46`.
**Bug fixes**

- Ensuring switches’ inputs are still hidden when `[disabled]` ([#778](https://github.com/elastic/eui/pull/778))

## [`0.0.46`](https://github.com/elastic/eui/tree/v0.0.46)

Expand Down
4 changes: 3 additions & 1 deletion src/components/form/switch/_switch.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,10 @@

/**
* 1. The input is "hidden" but still focusable.
* 2. Make sure it's still hidden when [disabled].
*/
.euiSwitch__input {
.euiSwitch__input,
.euiSwitch__input[disabled] /* 2 */ {
position: absolute;
opacity: 0; /* 1 */
width: 100%;
Expand Down