-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Storybook] Add stories for more components (leftovers) #7797
Merged
mgadewoll
merged 10 commits into
elastic:main
from
mgadewoll:storybook/add-missing-stories
Jun 4, 2024
Merged
[Storybook] Add stories for more components (leftovers) #7797
mgadewoll
merged 10 commits into
elastic:main
from
mgadewoll:storybook/add-missing-stories
Jun 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgadewoll
added
documentation
Issues or PRs that only affect documentation - will not need changelog entries
skip-changelog
labels
May 29, 2024
tkajtoch
reviewed
May 29, 2024
tkajtoch
reviewed
May 29, 2024
tkajtoch
reviewed
May 29, 2024
That's a solid PR! Code looks great, I found a few tiny things that we could improve. Let me know what you think! |
Preview staging links for this PR:
|
💚 Build Succeeded
History
|
tkajtoch
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for answering my questions and fixing bugs! LGTM 🚢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Issues or PRs that only affect documentation - will not need changelog entries
skip-changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds component stories for a couple of components that were not covered by the tasks of #7405 yet.
This PR adds stories and VRT reference imagesfor the following components:
ℹ️ ❓ Currently there are also no stories for subcomponents of
EuiComboBox
but those components also don't seem to be used standalone and might not make much sense to be used standalone anyway. We might want to not add stories for them.QA
Confirm that the prop controls for all the below stories provide relevant controls and that those controls work as expected:
https://eui.elastic.co/pr_7797/storybook/index.html?path=/story/tabular-content-euibasictable--playground
https://eui.elastic.co/pr_7797/storybook/index.html?path=/story/tabular-content-euibasictable--expanded-row
https://eui.elastic.co/pr_7797/storybook/index.html?path=/story/forms-euidatepickerrange--playground
https://eui.elastic.co/pr_7797/storybook/index.html?path=/story/forms-euisuperdatepicker-euisuperdatepicker--playground
https://eui.elastic.co/pr_7797/storybook/index.html?path=/story/forms-euisuperdatepicker-euisuperdatepicker--custom-quick-select-panel
https://eui.elastic.co/pr_7797/storybook/index.html?path=/story/forms-euisuperdatepicker-euisuperupdatebutton--playground
https://eui.elastic.co/pr_7797/storybook/index.html?path=/story/forms-euiautorefresh-euiautorefresh--playground
https://eui.elastic.co/pr_7797/storybook/index.html?path=/story/forms-euiautorefresh-euiautorefreshbutton--playground
https://eui.elastic.co/pr_7797/storybook/index.html?path=/story/forms-euirefreshinterval--playground