Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiIcon] Update logoElasticStack logo to latest #7838

Merged
merged 10 commits into from
Jun 18, 2024
Merged

[EuiIcon] Update logoElasticStack logo to latest #7838

merged 10 commits into from
Jun 18, 2024
+26 −37

Conversation

formgeist
Copy link
Contributor

Summary

Fixes #7834

Before

image

After

CleanShot 2024-06-17 at 11 34 08@2x

QA

Remove or strikethrough items that do not apply to your PR.

General checklist

  • Browser QA
    • Checked in both light and dark modes
  • Code quality checklist
  • Designer checklist
    • Updated the Figma library counterpart

@formgeist formgeist requested a review from a team as a code owner June 17, 2024 09:35
@formgeist formgeist self-assigned this Jun 17, 2024
mgadewoll
mgadewoll approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@mgadewoll mgadewoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ I updated the changelog file in this commit to reference the correct PR, other than that looking good to me 👍

@formgeist
Copy link
Contributor Author

ℹ️ I updated the changelog file in this commit to reference the correct PR, other than that looking good to me 👍

Thanks @mgadewoll 👍

@cee-chen
Copy link
Contributor

@MichaelMarcialis Did you want to review this before merge or can we go ahead and get it in?

MichaelMarcialis
MichaelMarcialis approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@MichaelMarcialis MichaelMarcialis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together, @formgeist! I left a few small SVG suggestions below. If you make those, recompile the icons, and update the jest snapshots, I think this should be good to go. Approving now so I don't hold you up.

packages/eui/src/components/icon/svgs/logo_elastic_stack.svg Outdated Show resolved Hide resolved
packages/eui/src/components/icon/svgs/logo_elastic_stack.svg Outdated Show resolved Hide resolved
packages/eui/src/components/icon/svgs/logo_elastic_stack.svg Outdated Show resolved Hide resolved
packages/eui/src/components/icon/svgs/logo_elastic_stack.svg Outdated Show resolved Hide resolved
formgeist and others added 6 commits June 18, 2024 08:59
@formgeist @MichaelMarcialis
Update packages/eui/src/components/icon/svgs/logo_elastic_stack.svg
8bd750b 
Co-authored-by: Michael Marcialis <michael.l.marcialis@gmail.com>
@formgeist @MichaelMarcialis
Update packages/eui/src/components/icon/svgs/logo_elastic_stack.svg
714c032 
Co-authored-by: Michael Marcialis <michael.l.marcialis@gmail.com>
@formgeist @MichaelMarcialis
Update packages/eui/src/components/icon/svgs/logo_elastic_stack.svg
5b1bc79 
Co-authored-by: Michael Marcialis <michael.l.marcialis@gmail.com>
@formgeist @MichaelMarcialis
Update packages/eui/src/components/icon/svgs/logo_elastic_stack.svg
2087e5c 
Co-authored-by: Michael Marcialis <michael.l.marcialis@gmail.com>
@formgeist
Recompiled and updated snapshots
56b6a91
@formgeist
Merge branch 'main' into update-icon-elastic-stack
caa827b
@formgeist
Copy link
Contributor Author

Thanks for putting this together, @formgeist! I left a few small SVG suggestions below. If you make those, recompile the icons, and update the jest snapshots, I think this should be good to go. Approving now so I don't hold you up.

Thanks for the suggested changes 👍 much cleaner!

@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @formgeist

@formgeist
Copy link
Contributor Author

@mgadewoll Perhaps you can do the honors of merging now that it's updated? Thanks

@mgadewoll mgadewoll merged commit dee9096 into elastic:main Jun 18, 2024
5 checks passed
@formgeist formgeist deleted the update-icon-elastic-stack branch June 18, 2024 08:42
@cee-chen cee-chen mentioned this pull request Jun 24, 2024
Merged
jbudz added a commit to elastic/kibana that referenced this pull request Jun 28, 2024
@cee-chen @jbudz
Upgrade EUI to v95.2.0 (#186841)
2bcc2fd 
`v95.1.0`⏩`v95.2.0`

_[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_

---

## [`v95.2.0`](https://github.com/elastic/eui/releases/v95.2.0)

- Updated `EuiContextMenuItemIcon`'s type definition to explicitly
define support for `EuiIcon`'s `IconType`
([#7804](elastic/eui#7804))
- Updated `EuiSteps` to support a new `titleSize="xxs"` style, which
outputs the same title font size but smaller unnumbered step indicators
([#7813](elastic/eui#7813))
- Updated `EuiStepsHorizontal` to support a new `size="xs"` style, which
outputs smaller unnumbered step indicators
([#7813](elastic/eui#7813))
- Updated `EuiStepNumber` to support new `titleSize="none"` which omits
rendering step numbers, and will only render icons
([#7813](elastic/eui#7813))
- Updated `setEuiDevProviderWarning` to additionally accept a custom
callback function, which warning messages will be passed to
([#7820](elastic/eui#7820))
- Updated `EuiIcon` to feature updated `logoElasticStack` logo for
referencing Elastic Stack platform
([#7838](elastic/eui#7838))
- Updated `EuiIcon` to feature updated `casesApp` design.
([#7840](elastic/eui#7840))
- Updated `EuiComboBox` to no longer autocomplete searched text when
used within forms ([#7842](elastic/eui#7842))

**CSS-in-JS conversions**

- Converted `EuiFilePicker` to Emotion; Removed
`$euiFilePickerTallHeight`
([#7833](elastic/eui#7833))

---------

Co-authored-by: Jon <jon@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgadewoll mgadewoll mgadewoll approved these changes

@MichaelMarcialis MichaelMarcialis MichaelMarcialis approved these changes

Assignees

@formgeist formgeist

Labels
icons
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[EuiIcon] Update the logoElasticStack icon to latest
6 participants
@formgeist @cee-chen @kibanamachine @elasticmachine @MichaelMarcialis @mgadewoll