Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated callout example #7986

Merged

Conversation

JasonStoltz
Copy link
Member

I updated the callout example to use a primary button rather than a secondary button, to provide better contrast.

I don't think this is a pattern we want to inadvertently encourage via our docs.

https://eui.elastic.co/#/display/callout

Before:
Screenshot 2024-08-23 at 3 00 48 PM

After:
Screenshot 2024-08-23 at 3 00 26 PM

I updated the callout example to use a primary
button rather than a secondary button, to
provide better contrast.

I don't think this is a pattern we want to
inadvertantly encourage via our docs.
Copy link
Member

@cee-chen cee-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cee-chen cee-chen added the documentation Issues or PRs that only affect documentation - will not need changelog entries label Aug 27, 2024
@JasonStoltz JasonStoltz enabled auto-merge (squash) August 27, 2024 18:47
@JasonStoltz JasonStoltz merged commit c6fe246 into elastic:main Aug 27, 2024
9 of 10 checks passed
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants