[Visual Refresh] Add behindText vis color tokens #8253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgadewoll
force-pushed
the
eui-theme/borealis-behind-text-tokens
branch
from
755606d to
7528314
Compare
|
Preview staging links for this PR:
|
💚 Build Succeeded
|
| @@ -266,6 +266,27 @@ export type _EuiThemeVisColors = { | |||
| euiColorVis8: string; | |||
| euiColorVis9: string; | |||
|
|
|||
| /* deprecated - temp token; used only during theme migration */ | |||
There was a problem hiding this comment.
non-blocking suggestion: How about we use the JSDoc @deprecated annotation for a strikethrough highlighting?
| @@ -62,6 +62,17 @@ export const colorVis: _EuiThemeVisColors = { | |||
| euiColorVis8: euiPaletteColorBlind.euiColorVis8.graphic, | |||
| euiColorVis9: euiPaletteColorBlind.euiColorVis9.graphic, | |||
|
|
|||
| euiColorVisBehindText0: '#6dccb1', | |||
There was a problem hiding this comment.
non-blocking suggestion: I understand that this is temporary but for better discoverability, consistency and clarity, can we add them in packages/eui/src/themes/amsterdam/global_styling/variables/_colors_vis.ts and use as ☝🏻 instead of hard-coding here? We could copy-paste them from packages/eui/src/themes/amsterdam/global_styling/variables/_colors_vis.scss.
We could also add a comment above them, similar to temp token; used only during theme migration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Note
This PR merges into a feature branch.
This PR adds
_behindTextvis color tokens. These have not been part of the theme, as they are not in usage in the new theme.During upgrades to the new theme, we realized that it's rather cumbersome for teams to migrate these JSON token usages properly to the
euiThemetokens without a 1:1 equivalent.These tokens are temporary for the purpose of making migration easier for Kibana teams. We will need to remove those tokens again at some point as they are not be used in Borealis.
QA
These tokens are not used anywhere. Make sure the values make sense:
Amsterdam - uses values returned from
euiPaletteColorBlindBehindText()Borealis maps to default vis colors
CI passes