make sure a toast has not already been dismissed when dismissing it #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcenizal
approved these changes
May 23, 2018
|
I couldn't replicate the issue within the existing test setup. I'll merge this to unblock things and then circle back and give it another try. Thanks @cjcenizal ! |
|
Sounds good! |
chandlerprall
added a commit
to chandlerprall/eui
that referenced
this pull request
May 24, 2018
…lastic#868) * make sure a toast has not already been dismissed when dismissing it * changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses elastic/kibana#19263 by making
EuiGlobalToastListmake sure it hasn't already dismissed a toast when it goes to dismiss a toast.