Fix bug where users could tab away from EuiComboBox while navigating the options list #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the options list.
cjcenizal
commented
Jun 14, 2018
| @@ -111,6 +121,53 @@ describe('props', () => { | |||
| }); | |||
|
|
|||
| describe('behavior', () => { | |||
| describe('tabbing', () => { | |||
| test.skip(`off the search input closes the options list if the user isn't navigating the options`, () => { | |||
There was a problem hiding this comment.
@chandlerprall Maybe you can help me debug this test...
|
Thanks for the assist, @chandlerprall! |
cjcenizal
force-pushed
the
combo-box-list-tab
branch
from
ccee273 to
fe5ade7
Compare
chandlerprall
approved these changes
Jun 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug I introduced in #866. In previous discussions, we decided to block the user from tabbing off the combo box if they're navigating through the options list. This mimics how Chrome blocks the user from tabbing off an open select.