Update golangci-lint version #3928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michel-laterman
added
Team:Elastic-Agent-Control-Plane
|
This pull request does not have a backport label. Could you fix it @michel-laterman? 🙏
|
|
|
mergify
bot
added
the
backport-8.x
|
jlind23
approved these changes
Sep 20, 2024
mergify bot
pushed a commit
that referenced
this pull request
Sep 20, 2024
(cherry picked from commit da96da3)
4 tasks
michel-laterman
added a commit
that referenced
this pull request
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem this PR solves?
Go version update to 1.23.x causes a lot of noise in the linter.
How does this PR solve the problem?
Update the linter used to 1.65.0, fix new issues.
The most common is a gosec G115 issue that attempts to find where we can have overflows caused by casting to/from int/uint (or int/int32).
Most of these are silenced as they would not be able to occur and there are false positives in the detector, see securego/gosec#1212