Revert "Skip tests that depend on 8.18.0-SNAPSHOT artifacts being available"

[ycombinator]

Reverts #4133 as it's now possible to create 8.18.0-SNAPSHOT deployments in the ESS production CFT region.

[pierrehilbert]

/test

[ycombinator]

E2E tests are failing like so:

=== RUN   TestAgentInstallSuite
--
  | agent_install_test.go:94:
  | Error Trace:	/opt/buildkite-agent/builds/bk-agent-prod-gcp-1732865060834845856/elastic/fleet-server/testing/e2e/agent_install_test.go:143
  | /opt/buildkite-agent/builds/bk-agent-prod-gcp-1732865060834845856/elastic/fleet-server/testing/e2e/agent_install_test.go:94
  | /opt/buildkite-agent/go/pkg/mod/github.com/stretchr/testify@v1.9.0/suite/suite.go:157
  | /opt/buildkite-agent/builds/bk-agent-prod-gcp-1732865060834845856/elastic/fleet-server/testing/e2e/agent_install_test.go:61
  | Error:      	Should be true
  | Test:       	TestAgentInstallSuite
  | Messages:   	unable to find package download for fileName = elastic-agent-8.18.0-SNAPSHOT-linux-x86_64.tar.gz

I'm not really sure why the package is not available for download, given that we have https://snapshots.elastic.co/8.18.0-4aa4b16c/summary-8.18.0-SNAPSHOT.html. @michel-laterman any thoughts?

[michel-laterman]

What the downloadAgent step does is do GET https://artifacts-api.elastic.co/v1/search/$VERSION-SNAPSHOT
then search the returned json body's packages object for the file.

I can see the package name if I manually do the request.

Maybe we should switch the download to GET https://artifacts-api.elastic.co/v1/downloads/elastic-agent-package/elastic-agent-8.18.0-SNAPSHOT-linux-x86_64.tar.gz directly?

[ycombinator]

@michel-laterman Thanks for attempting to fix the test in this PR but it appears to be still failing. Would you mind taking another look when you get a chance?

[michel-laterman]

The failure is now:

{"log.level":"info","@timestamp":"2024-12-02T22:22:40.097Z","log.origin":{"function":"github.com/elastic/elastic-agent/internal/pkg/agent/cmd.waitForFleetServer.func1","file.name":"cmd/enroll_cmd.go","file.line":826},"message":"Fleet Server - Error - failed version compatibility check with elasticsearch (Agent: 8.18.0-SNAPSHOT, Elasticsearch: 8.17.0): unsupported version","ecs.version":"1.6.0"}
--
  | Error: fleet-server failed: timed out waiting for Fleet Server to start after 2m0s

Which is expected as far as failure-cases go, this is because the .env file is still pointing to 8.17.x on the 8.x branch:

fleet-server/dev-tools/integration/.env

Line 3 in 3680c42

ELASTICSEARCH_VERSION=8.17.0-8ac6e7f5-SNAPSHOT

[ycombinator]

this is because the .env file is still pointing to 8.17.x on the 8.x branch:

fleet-server/dev-tools/integration/.env

Line 3 in 3680c42

ELASTICSEARCH_VERSION=8.17.0-8ac6e7f5-SNAPSHOT

Thanks @michel-laterman. @v1v Looks like https://github.com/elastic/fleet-server/actions/runs/12182478886 isn't running for the 8.x branch (which is now targeting 8.18.0). That would explain the above situation. Any ideas why this might be?

[v1v]

@v1v Looks like elastic/fleet-server/actions/runs/12182478886 isn't running for the 8.x branch (which is now targeting 8.18.0). That would explain the above situation. Any ideas why this might be?

https://storage.googleapis.com/artifacts-api/snapshots/branches.json was not reporting 8.x but 8.15, that's now fixed.

https://github.com/elastic/fleet-server/actions/runs/12196799407 ran and #4184 has been created with the change from 8.17 to 8.18

[ycombinator]

Thanks @v1v. Once #4184 is merged, I will rebase this PR on 8.x.

[elastic-sonarqube]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube