Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call tlscommon.SetInsecureDefaults #4238

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

michel-laterman
Copy link
Contributor

@michel-laterman michel-laterman commented Dec 19, 2024

What is the problem this PR solves?

Avoid a planned breaking change for tlscommon versions

How does this PR solve the problem?

Call tlscommon.SetInsecureDefaults in config init to reset version numbers to currently supported versions.

Design Checklist

  • I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.
  • I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.
  • I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool

Related Issues

@michel-laterman michel-laterman added backport Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team labels Dec 19, 2024
@michel-laterman michel-laterman requested a review from a team as a code owner December 19, 2024 19:50
@michel-laterman michel-laterman merged commit 18c2932 into elastic:8.x Dec 26, 2024
8 checks passed
@michel-laterman michel-laterman deleted the tls-insecure-defaults branch December 26, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants