This repository has been archived by the owner on Jan 31, 2024. It is now read-only.
Fix packages sort #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to compare resource group first, then fallback to resource version if the group is the same. The previous version of the sort algorithm did not work as expected in some situations, by comparing resources version even though their group does not match. Only the case where groupA < groupB was considered for group comparison, leading to a version comparison if groupA > groupB. This commit fixes it by making sure we evaluate version comparison only if groups are the same. It is verified by a unit test that does not pass with the previous version of the sort algorithm.
An issue prevents unit tests to run if flags are initialized in an init() function. More details there: golang/go#31859. A workaround is to init flags another way (here by calling a function from main()).
charith-elastic
approved these changes
Nov 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to compare resource group first, then fallback to resource
version if the group is the same. The previous version of the sort
algorithm did not work as expected in some situations, by comparing
resources version even though their group does not match.
Only the case where groupA < groupB was considered for group comparison,
leading to a version comparison if groupA > groupB.
This commit fixes it by making sure we evaluate version comparison only
if groups are the same.
It is verified by a unit test that does not pass with the previous
version of the sort algorithm.
To properly run a unit test in the same package as
main.go, Ihad to work around [this issue]{golang/go#31859).