Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose BulkIndexer total flushed bytes metric #914

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Expose BulkIndexer total flushed bytes metric #914

merged 1 commit into from
Nov 27, 2024

Conversation

aureleoules
Copy link
Contributor

@aureleoules aureleoules commented Oct 29, 2024 •
edited
Loading

This pull request exposes the amount of bytes flushed in total by the Bulk indexer.

I tested this change locally and it worked as expected.

@cla-checker-service CLA Checker Service
Copy link

cla-checker-service bot commented Oct 29, 2024 •
edited
Loading

💚 CLA has been signed

@aureleoules aureleoules force-pushed the aurele.oules/add-flushed-bytes-metric branch from 3c3ed2b to c723d77 Compare October 29, 2024 17:31
@aureleoules aureleoules marked this pull request as ready for review October 30, 2024 08:47
jbartosik
jbartosik reviewed Oct 31, 2024
View reviewed changes
esutil/bulk_indexer.go Show resolved Hide resolved
esutil/bulk_indexer.go Show resolved Hide resolved
jbartosik
jbartosik reviewed Nov 7, 2024
View reviewed changes
Copy link

@jbartosik jbartosik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

esutil/bulk_indexer.go Show resolved Hide resolved
esutil/bulk_indexer.go Show resolved Hide resolved
@mfpierre
Copy link

👋 Hey @Anaethelion,
could you have a look at this one? Exposing this stat in the client would be really helpful for us, thanks 🙏

@Anaethelion Anaethelion merged commit a7d1365 into elastic:main Nov 27, 2024
3 checks passed
Anaethelion pushed a commit that referenced this pull request Nov 27, 2024
@aureleoules @Anaethelion
Expose BulkIndexer total flushed bytes metric (#914)
3c51e00
Anaethelion pushed a commit that referenced this pull request Nov 27, 2024
@aureleoules @Anaethelion
Expose BulkIndexer total flushed bytes metric (#914)
20f90a8
Anaethelion pushed a commit that referenced this pull request Nov 27, 2024
@aureleoules @Anaethelion
Expose BulkIndexer total flushed bytes metric (#914)
06333fe
Anaethelion pushed a commit that referenced this pull request Nov 27, 2024
@aureleoules @Anaethelion
Expose BulkIndexer total flushed bytes metric (#914)
5438b48
This was referenced Nov 27, 2024
Merged
Merged
Merged
Merged
Anaethelion added a commit that referenced this pull request Nov 27, 2024
@Anaethelion @aureleoules
Expose BulkIndexer total flushed bytes metric (#914) (#931)
493dd6b 
Co-authored-by: Aurèle Oulès <aurele@oules.com>
Anaethelion added a commit that referenced this pull request Nov 27, 2024
@Anaethelion @aureleoules
Expose BulkIndexer total flushed bytes metric (#914) (#930)
21d8bc2 
Co-authored-by: Aurèle Oulès <aurele@oules.com>
Anaethelion added a commit that referenced this pull request Nov 27, 2024
@Anaethelion @aureleoules
Expose BulkIndexer total flushed bytes metric (#914) (#929)
bd1da00 
Co-authored-by: Aurèle Oulès <aurele@oules.com>
Anaethelion added a commit that referenced this pull request Nov 27, 2024
@Anaethelion @aureleoules
Expose BulkIndexer total flushed bytes metric (#914) (#928)
e921d93 
Co-authored-by: Aurèle Oulès <aurele@oules.com>
@aureleoules aureleoules mentioned this pull request Dec 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbartosik jbartosik jbartosik left review comments

@mfpierre mfpierre mfpierre approved these changes

@Anaethelion Anaethelion Anaethelion approved these changes

Assignees
No one assigned
Labels
backport 8.x backport 8.15 backport 8.16 backport 8.17
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aureleoules @mfpierre @jbartosik @Anaethelion