Check error in BaseClient.Perform #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The http.Resonse will be nil on errors, so return early. Fixes elastic#913
|
Thank you! |
Anaethelion
approved these changes
Nov 27, 2024
Anaethelion
added a commit
that referenced
this pull request
Nov 27, 2024
* Check error in BaseClient.Perform The http.Resonse will be nil on errors, so return early. Fixes #913 * revert reordering of imports --------- Co-authored-by: Laurent Saint-Félix <laurent.saintfelix@elastic.co>
Anaethelion
added a commit
that referenced
this pull request
Nov 27, 2024
* Check error in BaseClient.Perform The http.Resonse will be nil on errors, so return early. Fixes #913 * revert reordering of imports --------- Co-authored-by: Laurent Saint-Félix <laurent.saintfelix@elastic.co>
Anaethelion
added a commit
that referenced
this pull request
Nov 27, 2024
* Check error in BaseClient.Perform The http.Resonse will be nil on errors, so return early. Fixes #913 * revert reordering of imports --------- Co-authored-by: Laurent Saint-Félix <laurent.saintfelix@elastic.co>
Anaethelion
added a commit
that referenced
this pull request
Nov 27, 2024
Anaethelion
added a commit
that referenced
this pull request
Nov 27, 2024
* Check error in BaseClient.Perform The http.Resonse will be nil on errors, so return early. Fixes #913 * revert reordering of imports --------- Co-authored-by: Laurent Saint-Félix <laurent.saintfelix@elastic.co>
Anaethelion
added a commit
that referenced
this pull request
Nov 27, 2024
Anaethelion
added a commit
that referenced
this pull request
Nov 27, 2024
Anaethelion
added a commit
that referenced
this pull request
Nov 27, 2024
Anaethelion
added a commit
that referenced
this pull request
Nov 27, 2024
Anaethelion
added a commit
that referenced
this pull request
Nov 27, 2024
Cheers, I just did that because goimports automatically changed it, and figured I might as well get it right. By the way, would you mind also talking a look at my other patches (#905 and #906)? I need to use a fork because of that now 😅 I think #905 should be pretty straight-forward? #906 might need a bit more of a careful look(?) It's been working well for me in the last month, and without it a lot of times you don't get an actual meaningful error if you do something wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The http.Resonse will be nil on errors, so return early.
Fixes #913