Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update dependencies and bump go version #26

Merged
merged 10 commits into from
Sep 30, 2024

Conversation

kruskall
Copy link
Member

drop unnecessary dependencies and bump to a suppported go version

also update ci to use the go version specified in go.mod

WalkDir avoids calling os.Lstat on every visited file or directory
and was introduced in go 1.16
go 1.16 added the new embed package and pkger is archived
we are not using it anymore
@kruskall kruskall requested review from barkbay and removed request for ycombinator September 21, 2024 17:43
@barkbay
Copy link
Contributor

barkbay commented Sep 23, 2024

👀

Copy link
Contributor

@barkbay barkbay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR 🙇
I left a couple of nits but LGTM!

detector/detector.go Outdated Show resolved Hide resolved
detector/rules.go Outdated Show resolved Hide resolved
assignment copies lock value to transport: net/http.Transport contains sync.Mutex
@kruskall
Copy link
Member Author

Thanks for the review! 🙇

fyi I don't have permission to merge or create a new release

@barkbay barkbay merged commit b9dd1fb into elastic:master Sep 30, 2024
2 checks passed
@kruskall kruskall deleted the update/deps branch September 30, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants