Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenBSD: (*Mem).Get() returns zero with no error #72

Open
knz opened this issue May 10, 2017 · 4 comments
Open

OpenBSD: (*Mem).Get() returns zero with no error #72

knz opened this issue May 10, 2017 · 4 comments
Labels
bug

Comments

@knz
Copy link

knz commented May 10, 2017

Reported in cockroachdb/cockroach#15836

Using 64-bit OpenBSD
CockroachDB calls (*Mem).Get() and that returns zero with a nil error. The zero value is incorrect; an error should be returned instead.
@knz knz mentioned this issue May 10, 2017
Merged
@knz
Copy link
Author

knz commented May 10, 2017

cc @jasperla

@andrewkroh andrewkroh added the bug label May 10, 2017
@jasperla
Copy link

Ack, I'll investigate this weekend.

knz added a commit to knz/cockroach that referenced this issue May 12, 2017
@knz
server: catch incomplete available memory detection by gosigar
f161689 
If gosigar is told by a syscall there is 0 available memory, consider
this information as false even if there was no error.

Upstream issue: elastic/gosigar#72
mberhault pushed a commit to cockroachdb/cockroach that referenced this issue May 15, 2017
@knz
1.0.1 cherrypick: server: catch incomplete available memory detection…
4e69e5e 
… by gosigar

If gosigar is told by a syscall there is 0 available memory, consider
this information as false even if there was no error.

Upstream issue: elastic/gosigar#72
@mberhault mberhault mentioned this issue May 15, 2017
Merged
mberhault pushed a commit to cockroachdb/cockroach that referenced this issue May 15, 2017
@knz
server: catch incomplete available memory detection by gosigar
3f78a3f 
If gosigar is told by a syscall there is 0 available memory, consider
this information as false even if there was no error.

Upstream issue: elastic/gosigar#72
@jasperla jasperla mentioned this issue Jun 30, 2017
Open
@jasperla
Copy link

The issue was due to the fact that the underlying kernel structure changed and suddenly we reported 0 npages in use. It didn't fail to retrieve the data, it merely got the wrong data back. I've submitted a fix and some hardening against this type of situation.

@gballet
Copy link

gballet commented Dec 2, 2019

Also submitted a fix in #125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jasperla @knz @gballet @andrewkroh