forked from cloudfoundry/gosigar
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GetProcCredName implementation to windows gosigar #13
Merged
+61
−0
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -106,6 +106,7 @@ const ( | |
|
||
type ProcState struct { | ||
Name string | ||
Username string | ||
State RunState | ||
Ppid int | ||
Tty int | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think using
golang.org/x/sys/windows
would be better. That package haswindows.Token
with methods likeGetTokenUser
.The functions in that package will handle the ERROR_INSUFFICIENT_BUFFER that can be returned by
GetTokenInformation
. It also has a constant for TokenUser which makes code a little more clear (edit: you won't even need the TokenUser constant if you switch to usinggolang.org/x/sys/windows
).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think that is enough reason to use two libraries instead of just one? I'm worried that would confuse things having two libraries hit win32... otherwise we should probably just change ALL the windows method implementations to use golang.org/x/sys/windows instead of syscall.
The other windows gosigar methods use the syscall import to get at win32. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andrewkroh x/sys/windows would definitely simplify the account lookup and it looks really bullet proof from an error perspective... perhaps we could just use it for GetProcGredName and defer the re-implementation of the other methods to a later date and add an issue for that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it OK to use
golang.org/x/sys/windows
here and leave the other methods as is.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I'm silly! So x/sys/windows GetTokenUser is already there. When in Rome I guess :)
The
go x/foo/bar
thing threw me, definitely new to go.