Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[elasticsearch] Persistence annotations not working #183

Closed
eddycharly opened this issue Jun 21, 2019 · 2 comments · Fixed by #186
Closed

[elasticsearch] Persistence annotations not working #183

eddycharly opened this issue Jun 21, 2019 · 2 comments · Fixed by #186

Comments

@eddycharly
Copy link

Chart version:

7.1.1

Kubernetes version:

NA

Kubernetes provider: E.g. GKE (Google Kubernetes Engine)

AWS

Helm Version:

N1

Describe the bug:

pvc annotations in statefulset template is wrong.

see https://github.com/elastic/helm-charts/blob/7.1.1/elasticsearch/templates/statefulset.yaml#L26

the generated annotations will have incorrect indentation.
Crazybus added a commit that referenced this issue Jun 24, 2019
@Crazybus
[elasticsearch] Fix pvc annotations with multiple fields
2d309cb 
Fixes: #183

This worked just fine if there was only 1 annotation being added. When
adding multiple annotations the extra whitespace was causing it to
break.
@Crazybus Crazybus mentioned this issue Jun 24, 2019
Merged
4 tasks
@Crazybus
Copy link
Contributor

Thanks for reporting this! I have opened up #186 with the fix.

@eddycharly
Copy link
Author

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[elasticsearch] Fix pvc annotations with multiple fields elastic/helm-charts
2 participants
@Crazybus @eddycharly