Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[kibana/manage-es-token] scope/promise updates #1727

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Nov 15, 2022

This makes a few minor changes:

  • return nested promises to preserve the promise chain

  • scope secretData to the current block

  • Chart version not bumped (the versions are all bumped and released at the same time)

  • README.md updated with any new values or changes

  • Updated template tests in ${CHART}/tests/*.py

  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

This makes a few minor changes:
- return nested promises to preserve the promise chain
- scope secretData to the current block
Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM⛴

@jmlrt jmlrt merged commit 8e83ea4 into elastic:main Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants