[elasticsearch] Add service account and configure helpers.tpl #207
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
naseemkullah
force-pushed
the
es-sa
branch
2 times, most recently
from
29b7cb1 to
58b27df
Compare
Signed-off-by: Naseem <naseemkullah@gmail.com>
| @@ -91,6 +91,8 @@ helm install --name elasticsearch elastic/elasticsearch --version 7.2.0 --set im | |||
| | `httpPort` | The http port that Kubernetes will use for the healthchecks and the service. If you change this you will also need to set [http.port](https://www.elastic.co/guide/en/elasticsearch/reference/current/modules-http.html#_settings) in `extraEnvs` | `9200` | | |||
| | `transportPort` | The transport port that Kubernetes will use for the service. If you change this you will also need to set [transport port configuration](https://www.elastic.co/guide/en/elasticsearch/reference/current/modules-transport.html#_transport_settings) in `extraEnvs` | `9300` | | |||
| | `service.type` | Type of elasticsearch service. [Service Types](https://kubernetes.io/docs/concepts/services-networking/service/#publishing-services-service-types) | `ClusterIP` | | |||
| | `serviceAccount.create` | Create service account | `true` | | |||
There was a problem hiding this comment.
I didn't leave a comment on this PR since I left it on the Kibana PR (since they were opened at the same time both by you). But I think we should also rename this one to match with the suggestion for Kibana which matches filebeat and metricbeat too #208 (review)
There was a problem hiding this comment.
Sounds good! Sorry for dropping the ball on this a little, I'll get to it in the coming days!
There was a problem hiding this comment.
Please see #208 (comment)
There was a problem hiding this comment.
Seeing that this chart never had a serviceaccount, can we keep this one as is?
There was a problem hiding this comment.
That would be fine with me. Consistency between the charts would be nicer though.
|
Hi @naseemkullah, |
Signed-off-by: Naseem naseemkullah@gmail.com
${CHART}/tests/*.py${CHART}/examples/*/test/goss.yamlFixes #61