Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[elasticsearch] Drop version from chart label in service #290

Merged
merged 1 commit into from
Sep 19, 2019

Conversation

Crazybus
Copy link
Contributor

As identified in #284 having the version in the label would cause the
service to be recreated during a chart version upgrade.

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

As identified in #284 having the version in the label would cause the
service to be recreated during a chart version upgrade.
@Crazybus Crazybus requested a review from jmlrt September 18, 2019 14:34
Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tetianakravchenko
Copy link

tetianakravchenko commented Sep 18, 2019

Does it mean that to migrate to the next chart version (7.4) it will be required to reinstall the chart?

@Crazybus
Copy link
Contributor Author

Does it mean that to migrate to the next chart version (7.4) it will be required to reinstall the chart?

@tetianakravchenko Certainly not, and we will never purposefully bring in any breaking changes requiring a reinstall. We have an "upgrade" test as part of our automated testing pipeline https://github.com/elastic/helm-charts/blob/master/elasticsearch/examples/upgrade/Makefile to ensure that each releases remains backwards compatible with the initial 7.0.0 release.

@Crazybus Crazybus merged commit a39be2c into master Sep 19, 2019
@Crazybus Crazybus deleted the un_versionable branch September 19, 2019 09:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants