This repository has been archived by the owner on May 16, 2023. It is now read-only.
Make it possible to override the endpoint template. #298
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
${CHART}/tests/*.py
${CHART}/examples/*/test/goss.yaml
We would like to use the elasticsearch chart as a subchart, where the name of the resource needs to match the release name (the common structure used by many charts, like the official mariadb chart).
This was quite easy to do by overriding the helm template for
uname
andmasterService
(replacing their content with{{ .Release.Name }}-elasticsearch
), but theendpoints
template also needs to be overridden, and due to the way parameters are passed the trick above doesn't work.This change simply passes moves the specification of
.Values
to the helm template, enabling overrides to access top-level parameters like.Release.Name
. The behavior stays unchanged. This template is also not used anywhere else.