Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[elasticsearch] cleanup remaining pv(c) after goss tests #336

Closed
wants to merge 3 commits into from
Closed

[elasticsearch] cleanup remaining pv(c) after goss tests #336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
00cce78
[elasticsearch] cleanup remaining pv(c) after goss tests
jmlrt Oct 17, 2019
0a9304e
[elasticsearch] improve pvc purge
jmlrt Oct 18, 2019
401ca22
Merge branch 'master' into cleanup-pv-after-tests
jmlrt Jun 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions elasticsearch/examples/6.x/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,4 @@ test: install goss

purge:
helm del --purge $(RELEASE)
kubectl delete $$(kubectl get pvc -l release=$(RELEASE) -o name)
1 change: 1 addition & 0 deletions elasticsearch/examples/config/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,4 @@ test: secrets install goss

purge:
helm del --purge $(RELEASE)
kubectl delete $$(kubectl get pvc -l release=$(RELEASE) -o name)
1 change: 1 addition & 0 deletions elasticsearch/examples/default/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,4 @@ test: install goss

purge:
helm del --purge $(RELEASE)
kubectl delete $$(kubectl get pvc -l release=$(RELEASE) -o name)
1 change: 1 addition & 0 deletions elasticsearch/examples/docker-for-mac/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,4 @@ test: install

purge:
helm del --purge $(RELEASE)
kubectl delete $$(kubectl get pvc -l release=$(RELEASE) -o name)
1 change: 1 addition & 0 deletions elasticsearch/examples/kubernetes-kind/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,4 @@ test: install

purge:
helm del --purge $(RELEASE)
kubectl delete $$(kubectl get pvc -l release=$(RELEASE) -o name)
1 change: 1 addition & 0 deletions elasticsearch/examples/minikube/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,4 @@ test: install

purge:
helm del --purge $(RELEASE)
kubectl delete $$(kubectl get pvc -l release=$(RELEASE) -o name)
2 changes: 2 additions & 0 deletions elasticsearch/examples/multi/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,5 @@ test: install goss
purge:
helm del --purge $(PREFIX)-master
helm del --purge $(PREFIX)-data
kubectl delete $$(kubectl get pvc -l release=$(PREFIX)-master -o name)
kubectl delete $$(kubectl get pvc -l release=$(PREFIX)-data -o name)
1 change: 1 addition & 0 deletions elasticsearch/examples/openshift/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,4 @@ test: install goss

purge:
helm del --purge $(RELEASE)
kubectl delete $$(kubectl get pvc -l release=$(RELEASE) -o name)
1 change: 1 addition & 0 deletions elasticsearch/examples/oss/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,4 @@ test: install goss

purge:
helm del --purge $(RELEASE)
kubectl delete $$(kubectl get pvc -l release=$(RELEASE) -o name)
1 change: 1 addition & 0 deletions elasticsearch/examples/security/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ install:
purge:
kubectl delete secrets elastic-credentials elastic-certificates elastic-certificate-pem || true
helm del --purge $(RELEASE)
kubectl delete $$(kubectl get pvc -l release=$(RELEASE) -o name)

test: secrets install goss

Expand Down
1 change: 1 addition & 0 deletions elasticsearch/examples/upgrade/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,4 @@ test: init install goss

purge:
helm del --purge $(RELEASE)
kubectl delete $$(kubectl get pvc -l release=$(RELEASE) -o name)
1 change: 1 addition & 0 deletions elasticsearch/templates/statefulset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ spec:
selector:
matchLabels:
app: "{{ template "elasticsearch.uname" . }}"
release: {{ .Release.Name | quote }}
Copy link
Member Author

@jmlrt jmlrt Oct 21, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like changing spec.selector.matchLabels during statefulset upgrade is failing:

Error: UPGRADE FAILED: StatefulSet.apps "upgrade-master" is invalid: spec: Forbidden: updates to statefulset spec for fields other than 'replicas', 'template', and 'updateStrategy' are forbidden

elastic+helm-charts+pull-request+integration-elasticsearch/145/ES_SUITE=upgrade,KUBERNETES_VERSION=1.12

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm glad that upgrade test is in there and caught that!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems related to helm/charts#7680

replicas: {{ .Values.replicas }}
podManagementPolicy: {{ .Values.podManagementPolicy }}
updateStrategy:
Expand Down