This repository has been archived by the owner on May 16, 2023. It is now read-only.
[filebeat|metricbeat] Override probes commands #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmlrt
force-pushed
the
override-probe
branch
from
ba7f0ab to
4d6cad6
Compare
Crazybus
approved these changes
Dec 27, 2019
There was a problem hiding this comment.
LGTM!
FYI it would have already been possible to override the values for the sections which already had {{ toYaml .Values.readinessProbe | indent 10 }}. Since the hardcoded part is specified first anything added to .Values.readinessProbe would have overridden the hardcoded part. This way is much more obvious and cleaner though of course!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some outputs can't be tested using
filebeat test outputormetricbeat test outputcommands.Having these commands hardcoded in
ReadinessProbeprevent to use Filebeat / Metricbeat with outputs which haven't implemented the test command.Fix #316 and #325