Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[Kibana] remove useless maxUnavailable in Kibana chart #422

Merged
merged 2 commits into from
Dec 29, 2019

Conversation

victorsalaun
Copy link
Contributor

@victorsalaun victorsalaun commented Dec 29, 2019

This PR removes useless maxUnavailable attribute in Kibana chart
Solves #331

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmlrt
Copy link
Member

jmlrt commented Dec 29, 2019

jenkins test this please

Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @victorsalaun,

One minor confusion between Pod Disruption Budget and Rolling Update Deployment which both contains a maxUnavailable parameter.

While the maxUnavailable parameter value was related to Pod Disruption Budget, which we don't implement in Kibana chart, we can still specify updateStrategy.rollingUpdate.maxUnavailable value when changing Deployment update strategy from recreate to rollingUpdate, so test_override_the_default_update_strategy should continue to test this scenario.

@@ -191,15 +191,11 @@ def test_override_the_default_update_strategy():
config = '''
updateStrategy:
type: "RollingUpdate"
rollingUpdate:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this test should stay like that as it's testing adding a Rolling Update strategy to Kibana Deployment which is still valid, while maxUnavailable value should be used to define a Pod Disruption Budget resource as in Elasticsearch chart.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, indeed same name maxUnavailable but for different usage.
I reverted the deletion of the test.

Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmlrt
Copy link
Member

jmlrt commented Dec 29, 2019

jenkins test this please

@jmlrt jmlrt merged commit 51cffa9 into elastic:master Dec 29, 2019
@victorsalaun
Copy link
Contributor Author

Thanks @jmlrt

@victorsalaun victorsalaun deleted the kibana_maxUnavailable_removal branch December 29, 2019 16:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants