-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[Kibana] remove useless maxUnavailable in Kibana chart #422
[Kibana] remove useless maxUnavailable in Kibana chart #422
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⛴
jenkins test this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR @victorsalaun,
One minor confusion between Pod Disruption Budget and Rolling Update Deployment which both contains a maxUnavailable
parameter.
While the maxUnavailable
parameter value was related to Pod Disruption Budget, which we don't implement in Kibana chart, we can still specify updateStrategy.rollingUpdate.maxUnavailable
value when changing Deployment update strategy from recreate
to rollingUpdate
, so test_override_the_default_update_strategy
should continue to test this scenario.
kibana/tests/kibana_test.py
Outdated
@@ -191,15 +191,11 @@ def test_override_the_default_update_strategy(): | |||
config = ''' | |||
updateStrategy: | |||
type: "RollingUpdate" | |||
rollingUpdate: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, this test should stay like that as it's testing adding a Rolling Update strategy to Kibana Deployment which is still valid, while maxUnavailable
value should be used to define a Pod Disruption Budget resource as in Elasticsearch chart.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, indeed same name maxUnavailable
but for different usage.
I reverted the deletion of the test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⛴
jenkins test this please |
Thanks @jmlrt |
This PR removes useless
maxUnavailable
attribute in Kibana chartSolves #331
${CHART}/tests/*.py
${CHART}/examples/*/test/goss.yaml