-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Author of the following commits did not sign a Contributor Agreement: Please, read and sign the above mentioned agreement if you want to contribute to this project |
This PR is to address an issue I've run into when rendering the chart using HELM and deploying with Kubectl. The error message in Azure DevOps is:
Upon closer examination, a fragment of the rendered stateful set looks like this: template:
metadata:
name: "microk8s-master"
labels:
heritage: "Helm"
release: "elk-es"
chart: "elasticsearch"
app: "microk8s-master"
app: "microk8s-master" The duplicate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, 🤦♂ I didn't see it when I reviewed the PR which introduced it...
Thanks for the fix ❤️
jenkins test this please |
awesome, @jmlrt when do you think this will be available in the chart itself? |
|
@jmlrt do you guys have an ETA for the next release? Didn't realize you guys were ok with having a broken chart in the registry for that long |
@mmisztal1980 No ETA except that it will be released with the rest of Elastic Stack in a few weeks. Note that the chart is working well with GKE and other tested k8s providers even with the duplicated label so we're not considering chart broken. |
${CHART}/tests/*.py
${CHART}/examples/*/test/goss.yaml