Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

duplicate label removed #428

Merged
merged 1 commit into from
Jan 6, 2020
Merged

Conversation

mmisztal1980
Copy link
Contributor

@mmisztal1980 mmisztal1980 commented Jan 3, 2020

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

Author of the following commits did not sign a Contributor Agreement:
b39b076

Please, read and sign the above mentioned agreement if you want to contribute to this project

@mmisztal1980
Copy link
Contributor Author

This PR is to address an issue I've run into when rendering the chart using HELM and deploying with Kubectl. The error message in Azure DevOps is:

  • duplicated mapping key at line 40, column 31:

Upon closer examination, a fragment of the rendered stateful set looks like this:

template:
    metadata:
      name: "microk8s-master"
      labels:
        heritage: "Helm"
        release: "elk-es"
        chart: "elasticsearch"
        app: "microk8s-master"
        app: "microk8s-master"

The duplicate app key is caused by it's dual presence in the HELM template, which is being addressed by this PR

Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 🤦‍♂ I didn't see it when I reviewed the PR which introduced it...
Thanks for the fix ❤️

@jmlrt
Copy link
Member

jmlrt commented Jan 6, 2020

jenkins test this please

@jmlrt jmlrt merged commit 0b9202f into elastic:master Jan 6, 2020
@mmisztal1980
Copy link
Contributor Author

awesome, @jmlrt when do you think this will be available in the chart itself?

@jmlrt
Copy link
Member

jmlrt commented Jan 6, 2020

  • If you're deploying the chart using master branch, it's already available.

  • If you're using Helm repo, it will be available with next Elastic Stack release in a few weeks.

@mmisztal1980 mmisztal1980 deleted the bug/duplicate-labels branch January 7, 2020 20:33
@mmisztal1980
Copy link
Contributor Author

@jmlrt do you guys have an ETA for the next release? Didn't realize you guys were ok with having a broken chart in the registry for that long

@jmlrt
Copy link
Member

jmlrt commented Jan 7, 2020

@mmisztal1980 No ETA except that it will be released with the rest of Elastic Stack in a few weeks.

Note that the chart is working well with GKE and other tested k8s providers even with the duplicated label so we're not considering chart broken.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants