Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Freeze pip dependencies to make make pytest work #463

Merged
merged 1 commit into from
Jan 31, 2020

Conversation

morganchristiansson
Copy link
Contributor

@morganchristiansson morganchristiansson commented Jan 28, 2020

Updates requirements.txt same as #309 did for helpers/helm-tester/requirements.txt

  • freezing attrs to 19.1.0 fix TypeError: attrib() got an unexpected keyword argument 'convert' issue that we have with 19.2.0

  • also freezing other dependencies for safety

  • Chart version not bumped (the versions are all bumped and released at the same time)

Updates requirements.txt same as elastic#309 did for helpers/helm-tester/requirements.txt

- freezing attrs to 19.1.0 fix `TypeError: attrib() got an unexpected keyword argument 'convert'` issue that we have with 19.2.0
- also freezing other dependencies for safety
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmlrt
Copy link
Member

jmlrt commented Jan 31, 2020

jenkins test this please

@jmlrt jmlrt merged commit 7917345 into elastic:master Jan 31, 2020
@morganchristiansson morganchristiansson deleted the freeze-attrs-dependency branch May 6, 2021 18:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants