-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[apm-server]Fix fullnameOverride setting #508
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
jenkins test this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
black formatter requires that variables are surrounding by double quotes instead of single quotes. The rest LGTM 👍
jenkins test this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
apm-server/tests/apmserver_test.py
Outdated
"name" | ||
] | ||
== project | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think black is now complaining about the missing newline :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, fixed.
jenkins test this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
${CHART}/tests/*.py
${CHART}/examples/*/test/goss.yaml