Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[apm-server]Fix fullnameOverride setting #508

Merged
merged 4 commits into from
Mar 6, 2020
Merged

Conversation

kawat55
Copy link
Contributor

@kawat55 kawat55 commented Mar 6, 2020

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@kawat55 kawat55 closed this Mar 6, 2020
@kawat55 kawat55 reopened this Mar 6, 2020
@jmlrt jmlrt self-requested a review March 6, 2020 06:01
@jmlrt jmlrt added the bug Something isn't working label Mar 6, 2020
@jmlrt
Copy link
Member

jmlrt commented Mar 6, 2020

jenkins test this please

Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

black formatter requires that variables are surrounding by double quotes instead of single quotes. The rest LGTM 👍

apm-server/tests/apmserver_test.py Outdated Show resolved Hide resolved
@jmlrt
Copy link
Member

jmlrt commented Mar 6, 2020

jenkins test this please

Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

"name"
]
== project
)
Copy link
Member

@jmlrt jmlrt Mar 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think black is now complaining about the missing newline :(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, fixed.

@jmlrt
Copy link
Member

jmlrt commented Mar 6, 2020

jenkins test this please

Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmlrt jmlrt merged commit 66602b9 into elastic:master Mar 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants