Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Update defaults for extra values to support lists #522

Merged
merged 5 commits into from
Apr 21, 2020

Conversation

domgoodwin
Copy link
Contributor

@domgoodwin domgoodwin commented Mar 17, 2020

Currently if you specify extraEnvs, extraVolumes or extraVolumeMounts it breaks the deployment. Updated so field looks for lists and not strings.

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@jmlrt
Copy link
Member

jmlrt commented Mar 18, 2020

jenkins test this please

@jmlrt jmlrt added the enhancement New feature or request label Mar 19, 2020
@jmlrt
Copy link
Member

jmlrt commented Apr 20, 2020

related to #530

@jmlrt
Copy link
Member

jmlrt commented Apr 20, 2020

jenkins test this please

@domgoodwin
Copy link
Contributor Author

There was an issue with the initContainer check, so I merged in latest from master

@jmlrt
Copy link
Member

jmlrt commented Apr 20, 2020

jenkins test this please

@domgoodwin
Copy link
Contributor Author

Looking at the filebeat PR, would you suggest adding the same pattern - where if string use the old method if not parse the yaml?

@jmlrt
Copy link
Member

jmlrt commented Apr 21, 2020

jenkins test this please

Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you for this PR 👍

elasticsearch/templates/statefulset.yaml Show resolved Hide resolved
elasticsearch/templates/statefulset.yaml Outdated Show resolved Hide resolved
@domgoodwin
Copy link
Contributor Author

I've updated with the requested changes now

@jmlrt
Copy link
Member

jmlrt commented Apr 21, 2020

jenkins test this please

@jmlrt jmlrt self-assigned this Apr 21, 2020
Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes are required to make Black formatter happy in elastic+helm-charts+pull-request+lint-python/149. Hope this is the last change to do.

@domgoodwin
Copy link
Contributor Author

I think I've fixed the linting errors, the jenkins console log was hard to read honestly

@jmlrt
Copy link
Member

jmlrt commented Apr 21, 2020

jenlins test this please

Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you 👍

@jmlrt jmlrt merged commit 8cc14b7 into elastic:master Apr 21, 2020
@jmlrt jmlrt added the v7.7.0 label Apr 21, 2020
jmlrt added a commit that referenced this pull request Apr 21, 2020
Update defaults for extra values to support lists
@jmlrt
Copy link
Member

jmlrt commented Apr 21, 2020

backported to 7.7 branch in bcaaaad

@jmlrt jmlrt mentioned this pull request Oct 28, 2020
This was referenced Nov 17, 2020
This was referenced Nov 19, 2020
@jmlrt jmlrt mentioned this pull request Feb 8, 2021
This was referenced Mar 15, 2021
@jmlrt jmlrt mentioned this pull request May 25, 2021
@jmlrt jmlrt mentioned this pull request Mar 8, 2022
@jmlrt jmlrt mentioned this pull request Apr 21, 2022
This was referenced Sep 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request v7.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants