Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[testing] Ensure that the 'namespace' is specified in Helm command #715

Merged
merged 1 commit into from
Jul 8, 2020
Merged

[testing] Ensure that the 'namespace' is specified in Helm command #715

merged 1 commit into from
Jul 8, 2020

Conversation

fatmcgav
Copy link
Contributor

@fatmcgav fatmcgav commented Jul 7, 2020

If the --namespace flag isn't provided to Helm, then it will use whatever the local configured namespace is, which could be different.

This can lead to tests failing that expect the .Release.Namespace to resolve to default

[testing] Ensure that the 'namespace' is specified in Helm command
db2bb06 
If the `--namespace` flag isn't provided to Helm, then it will use whatever the local configured namespace is, which could be different.

This can lead to tests failing that expect the `.Release.Namespace` to resolve to `default`
@fatmcgav fatmcgav requested review from mgreau, Conky5, Crazybus and jmlrt July 7, 2020 16:21
@fatmcgav fatmcgav self-assigned this Jul 7, 2020
@fatmcgav
Copy link
Contributor Author

fatmcgav commented Jul 7, 2020

This came up from #702 (comment)

mgreau
mgreau approved these changes Jul 7, 2020
View reviewed changes
Copy link
Member

@mgreau mgreau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fatmcgav fatmcgav merged commit fbfef43 into master Jul 8, 2020
@fatmcgav fatmcgav deleted the helm_namespace_default branch July 8, 2020 08:44
fatmcgav pushed a commit that referenced this pull request Jul 8, 2020
[testing] Ensure that the 'namespace' is specified in Helm command (#715
feec797 
)

If the `--namespace` flag isn't provided to Helm, then it will use whatever the local configured namespace is, which could be different.

This can lead to tests failing that expect the `.Release.Namespace` to resolve to `default`
fatmcgav pushed a commit that referenced this pull request Jul 8, 2020
[testing] Ensure that the 'namespace' is specified in Helm command (#715
6b5b3bb 
)

If the `--namespace` flag isn't provided to Helm, then it will use whatever the local configured namespace is, which could be different.

This can lead to tests failing that expect the `.Release.Namespace` to resolve to `default`
fatmcgav pushed a commit that referenced this pull request Jul 8, 2020
[testing] Ensure that the 'namespace' is specified in Helm command (#715
1f9e006 
)

If the `--namespace` flag isn't provided to Helm, then it will use whatever the local configured namespace is, which could be different.

This can lead to tests failing that expect the `.Release.Namespace` to resolve to `default`
@fatmcgav fatmcgav mentioned this pull request Jul 8, 2020
Closed
This was referenced Jul 16, 2020
Closed
Closed
This was referenced Jul 27, 2020
Merged
Merged
@jmlrt jmlrt mentioned this pull request Oct 28, 2020
Closed
This was referenced Nov 17, 2020
Closed
Closed
Closed
Closed
Closed
@jmlrt jmlrt mentioned this pull request Feb 8, 2021
Closed
This was referenced Mar 15, 2021
Closed
Closed
@jmlrt jmlrt mentioned this pull request May 25, 2021
Closed
This was referenced Dec 14, 2021
Merged
Merged
Merged
@jmlrt jmlrt mentioned this pull request Mar 8, 2022
Merged
@jmlrt jmlrt mentioned this pull request Apr 21, 2022
Merged
This was referenced Sep 14, 2022
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mgreau mgreau mgreau approved these changes

@Conky5 Conky5 Awaiting requested review from Conky5

@Crazybus Crazybus Awaiting requested review from Crazybus

@jmlrt jmlrt Awaiting requested review from jmlrt

Assignees

@fatmcgav fatmcgav

Labels
v6.8.11 v7.8.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fatmcgav @mgreau