Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[Kibana] Add loadbalancerIP to service spec in kibana #726

Merged
merged 2 commits into from
Jul 16, 2020
Merged

[Kibana] Add loadbalancerIP to service spec in kibana #726

merged 2 commits into from
Jul 16, 2020

Conversation

debojitkakoti
Copy link
Contributor

@debojitkakoti debojitkakoti commented Jul 14, 2020

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml
    Closes #loadBalancerIP in service - Kibana #611

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@debojitkakoti debojitkakoti changed the title Add loadbalancerIP to service spec in kibana [Kibana] Add loadbalancerIP to service spec in kibana Jul 14, 2020
@debojitkakoti debojitkakoti marked this pull request as ready for review July 14, 2020 10:35
jmlrt
jmlrt previously approved these changes Jul 15, 2020
Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM⛴

@jmlrt
Copy link
Member

jmlrt commented Jul 15, 2020

jenkins test this please

@jmlrt
Copy link
Member

jmlrt commented Jul 15, 2020

Some changes are required to make Black formatter happy in elastic+helm-charts+pull-request+lint-python/368.

Can you run black kibana/tests/kibana_test.py?

@debojitkakoti
Copy link
Contributor Author

debojitkakoti commented Jul 16, 2020

@jmlrt I have formatted the code, can you check now?

@debojitkakoti debojitkakoti requested a review from jmlrt July 16, 2020 06:05
@jmlrt
Copy link
Member

jmlrt commented Jul 16, 2020

jenkins test this please

Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM⛴

@jmlrt
Copy link
Member

jmlrt commented Jul 16, 2020

backported to 6.8, 7.8and 7.x branches

This was referenced Jul 27, 2020
@jmlrt jmlrt mentioned this pull request Oct 28, 2020
@jmlrt jmlrt mentioned this pull request Nov 17, 2020
This was referenced Nov 17, 2020
@jmlrt jmlrt mentioned this pull request Feb 8, 2021
This was referenced Mar 15, 2021
@jmlrt jmlrt mentioned this pull request May 25, 2021
@jmlrt jmlrt mentioned this pull request Mar 8, 2022
@jmlrt jmlrt mentioned this pull request Apr 21, 2022
This was referenced Sep 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants