Add release notes for elastic/kibana#191730 #1292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
|
This pull request does not have a backport label. Could you fix it @jsoriano? 🙏
|
kpollich
reviewed
Sep 5, 2024
|
Added it also as a known issue. |
kpollich
approved these changes
Sep 5, 2024
mergify bot
pushed a commit
that referenced
this pull request
Sep 5, 2024
(cherry picked from commit 4928797)
jsoriano
added a commit
to elastic/kibana
that referenced
this pull request
Sep 6, 2024
…emplate (#191730)" (#191897) (#192246) This change was released at the end in 8.15.1, so let's keep it the branch. There are definitions of nested objects whose fields are defined as subfields, like this: ``` - name: a type: nested fields: - name: b type: keyword ``` This should generate a template with the subfields as subproperties: ``` "properties": { ... "a": { "type": "nested", "properties": { "b": { "ignore_above": 1024, "type": "keyword", }, }, }, }, ``` This change adds support for this. Without it the nested object is empty, without subfields, what is unexpected. See elastic/package-spec#784 for more context. This change was originally reverted in 8.15 in #191897 Release notes were manually added in elastic/ingest-docs#1292
jsoriano
added a commit
that referenced
this pull request
Sep 9, 2024
(cherry picked from commit 4928797) Co-authored-by: Jaime Soriano Pastor <jsorianopastor@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was originally not intended to be released in 8.15.1, but we are including it at the end.
elastic/kibana#191730