[Kubernetes] Add last_terminated_timestamp metric to state_container datastream #10503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
MichaelKatsoulis
approved these changes
Jul 16, 2024
gizas
reviewed
Jul 16, 2024
| @@ -32,6 +32,9 @@ | |||
| type: keyword | |||
| description: > | |||
| The last reason the container was in terminated state (Completed, ContainerCannotRun, Error or OOMKilled). | |||
| - name: last_terminated_timestamp | |||
| type: double | |||
There was a problem hiding this comment.
Small question: how this field is displayed if you change the type to date ?
Because I see other timestamp fields are marked as such
There was a problem hiding this comment.
@gizas If changed to date:
{"log.level":"warn","@timestamp":"2024-07-16T09:17:20.612Z","message":"Cannot index event (status=400): dropping event! Look at the event log to view the event and cause." ...
some of fields indeed are of type date, but some - long or double, I've listed it here - elastic/beats#39200 (comment)
gizas
approved these changes
Jul 16, 2024
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
|
|
|
Package kubernetes - 1.65.0 containing this change is available at https://epr.elastic.co/search?package=kubernetes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Relates elastic/elastic-agent#3802
Related issues
Screenshots