Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GCP] Add GCP Billing Metricset #2141

Merged
merged 3 commits into from
Nov 30, 2021
Merged

[GCP] Add GCP Billing Metricset #2141

merged 3 commits into from
Nov 30, 2021

Conversation

legoguy1000
Copy link
Contributor

What does this PR do?

Add GCP Billing Metricset

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

Author's Checklist

How to test this PR locally

Related issues

Screenshots

@legoguy1000
Copy link
Contributor Author

legoguy1000 commented Nov 8, 2021 •
edited
Loading

@endorama Split from #2066

@elasticmachine
Copy link

elasticmachine commented Nov 8, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-11-16T17:17:42.501+0000

  • Duration: 18 min 47 sec

  • Commit: a39a970

Test stats 🧪

Test Results
Failed 0
Passed 32
Skipped 0
Total 32

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@endorama
Copy link
Member

/test

@legoguy1000
Copy link
Contributor Author

@endorama Per #2066 (comment), I figured but didn't want to assume. I can update this branch.

@endorama
Copy link
Member

@legoguy1000 yes please! Thanks

@legoguy1000
Copy link
Contributor Author

@endorama updated. Ready for review/test.

@endorama
Copy link
Member

/test

@legoguy1000
Copy link
Contributor Author

legoguy1000 commented Nov 25, 2021 •
edited
Loading

@endorama Are you good to merge this? Then I can start on the others.

@endorama
Copy link
Member

Hello @legoguy1000 I've been working on adding tests but is taking longer than expected. The PR works and tests are green, so I'm going to merge and continue working in the background.

Thank you for the contribution!

@endorama endorama merged commit 6d69fec into elastic:gcp-metrics Nov 30, 2021
@legoguy1000 legoguy1000 deleted the 490-gcp-billing branch November 30, 2021 15:31
@legoguy1000
Copy link
Contributor Author

@endorama do u want me to start building the other PRs for the other metric data sets?

@endorama
Copy link
Member

Yes please.

endorama pushed a commit that referenced this pull request Feb 1, 2022
@legoguy1000 @endorama
[GCP] Add GCP Billing Metricset (#2141)
64004cd
@endorama endorama mentioned this pull request Feb 16, 2022
Merged
4 tasks
@endorama endorama mentioned this pull request Mar 2, 2022
Closed
11 tasks
endorama pushed a commit that referenced this pull request Mar 17, 2022
@legoguy1000 @endorama
[GCP] Add GCP Billing Metricset (#2141)
8b9af3c
endorama pushed a commit that referenced this pull request Mar 18, 2022
@legoguy1000 @endorama
[GCP] Add GCP Billing Metricset (#2141)
de741ef 
This commit has been changed to remove changes to README included in
 #2141 to allow documentation changes from #2842

Changes to  packages/gcp/data_stream/audit/manifest.yml has been removed
too.
endorama pushed a commit that referenced this pull request Mar 18, 2022
@legoguy1000 @endorama
[GCP] Add GCP Compute Metricset (#2301)
7ed83f9 
This commit has been changed to remove changes to README included in
 #2141 to allow documentation changes from #2842
endorama pushed a commit that referenced this pull request Mar 22, 2022
@legoguy1000 @endorama
[GCP] Add GCP Billing Metricset (#2141)
e70e471 
This commit has been changed to remove changes to README included in
 #2141 to allow documentation changes from #2842

Changes to  packages/gcp/data_stream/audit/manifest.yml has been removed
too.
endorama pushed a commit that referenced this pull request Mar 22, 2022
@legoguy1000 @endorama
[GCP] Add GCP Compute Metricset (#2301)
376a5e9 
This commit has been changed to remove changes to README included in
 #2141 to allow documentation changes from #2842
gpop63 pushed a commit to gpop63/integrations that referenced this pull request Mar 23, 2022
@legoguy1000 @gpop63
[GCP] Add GCP Billing Metricset (elastic#2141)
418224b
gpop63 pushed a commit to gpop63/integrations that referenced this pull request Mar 23, 2022
@legoguy1000 @gpop63
[GCP] Add GCP Billing Metricset (elastic#2141)
e3cfa71
gpop63 added a commit that referenced this pull request Mar 30, 2022
@gpop63 @endorama @legoguy1000
[GCP] Add firestore data_stream (#2704)
aaab6bd 
* gcp: stub logs and metrics doc files

* [GCP] Add GCP Billing Metricset (#2141)

* [GCP] Add GCP Compute Metricset (#2301)

* [GCP] Add GCP Billing Metricset (#2141)

* [GCP] Add GCP Compute Metricset (#2301)

* Add firestore data_stream

* Fix formatting issue

* Add gcp tests env vars in Jenkinsfile

* Add missing env fields

* Update terraform deployer

* Update system test

* Fix credentials json field

* Format & add period

* Update docs

* Update default period for firestoer

* Update terraform deployer

* Remove period from system test

* Update manifest version

* Update manifest file

* Add default project id

* Fix owner

* Update audit docs

* Fix terraform deployer

* Remove redundant alternative host

* Fix project variable

* Remove default project string

* Remove firestore datastream tests

* Revert "Add gcp tests env vars in Jenkinsfile"

This reverts commit ceea735.

Co-authored-by: Edoardo Tenani <edoardo.tenani@elastic.co>
Co-authored-by: Alex Resnick <adr8292@gmail.com>
endorama pushed a commit that referenced this pull request Apr 5, 2022
@legoguy1000 @endorama
[GCP] Add GCP Billing Metricset (#2141)
9718549 
This commit has been changed to remove changes to README included in
 #2141 to allow documentation changes from #2842

Changes to  packages/gcp/data_stream/audit/manifest.yml has been removed
too.
endorama pushed a commit that referenced this pull request Apr 5, 2022
@legoguy1000 @endorama
[GCP] Add GCP Compute Metricset (#2301)
330797b 
This commit has been changed to remove changes to README included in
 #2141 to allow documentation changes from #2842
endorama pushed a commit that referenced this pull request Jun 9, 2022
@legoguy1000 @endorama
[GCP] Add GCP Billing Metricset (#2141)
87bc0ca 
This commit has been changed to remove changes to README included in
 #2141 to allow documentation changes from #2842

Changes to  packages/gcp/data_stream/audit/manifest.yml has been removed
too.
endorama pushed a commit that referenced this pull request Jun 9, 2022
@legoguy1000 @endorama
[GCP] Add GCP Compute Metricset (#2301)
8947679 
This commit has been changed to remove changes to README included in
 #2141 to allow documentation changes from #2842
endorama pushed a commit that referenced this pull request Jul 12, 2022
@legoguy1000 @endorama
[GCP] Add GCP Billing Metricset (#2141)
25c29cd 
This commit has been changed to remove changes to README included in
 #2141 to allow documentation changes from #2842

Changes to  packages/gcp/data_stream/audit/manifest.yml has been removed
too.
endorama pushed a commit that referenced this pull request Jul 12, 2022
@legoguy1000 @endorama
[GCP] Add GCP Compute Metricset (#2301)
fa41120 
This commit has been changed to remove changes to README included in
 #2141 to allow documentation changes from #2842
@andrewkroh andrewkroh mentioned this pull request Jul 18, 2022
Closed
@andrewkroh andrewkroh mentioned this pull request Jul 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endorama endorama endorama left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@legoguy1000 @elasticmachine @endorama