Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scripts to used datastream.dataset for dashboards #216

Closed
wants to merge 2 commits into from

Conversation

ruflin
Copy link
Contributor

@ruflin ruflin commented Aug 4, 2020

The agent will ship datastream.* fields. Because of this, the import scripts can be adjusted to only use these fields.

This PR doese not rename any Golang variables. This should be done in a follow up and in sync with potential changes to the registry.

The agent will ship datastream.* fields. Because of this, the import scripts can be adjusted to only use these fields.

This PR doese not rename any Golang variables. This should be done in a follow up and in sync with potential changes to the registry.
@ruflin ruflin requested a review from mtojek August 4, 2020 08:34
@ruflin ruflin self-assigned this Aug 4, 2020
@elasticmachine
Copy link

elasticmachine commented Aug 4, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #216 updated]

  • Start Time: 2020-08-04T09:09:17.683+0000

  • Duration: 3 min 42 sec

Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I believe you could combine this one together with #213

@ruflin
Copy link
Contributor Author

ruflin commented Aug 4, 2020

Closing in favor of #213

@ruflin ruflin closed this Aug 4, 2020
@ruflin ruflin deleted the adjust-datastream-fields branch August 4, 2020 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants