-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add system test for CrowdStrike Falcon #429
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a system test for CrowdStrike Falcon and fix the issues it detected. These were the errors initially detected. crowdstrike/falcon : [0] field "crowdstrike.event.PatternDispositionFlags.Detect" is undefined [1] field "crowdstrike.event.PatternDispositionFlags.InddetMask" is undefined [2] field "crowdstrike.event.PatternDispositionFlags.Indicator" is undefined [3] field "crowdstrike.event.PatternDispositionFlags.KillParent" is undefined [4] field "crowdstrike.event.PatternDispositionFlags.KillProcess" is undefined [5] field "crowdstrike.event.PatternDispositionFlags.KillSubProcess" is undefined [6] field "crowdstrike.event.PatternDispositionFlags.OperationBlocked" is undefined [7] field "crowdstrike.event.PatternDispositionFlags.PolicyDisabled" is undefined [8] field "crowdstrike.event.PatternDispositionFlags.ProcessBlocked" is undefined [9] field "crowdstrike.event.PatternDispositionFlags.QuarantineFile" is undefined [10] field "crowdstrike.event.PatternDispositionFlags.QuarantineMachine" is undefined [11] field "crowdstrike.event.PatternDispositionFlags.Rooting" is undefined [12] field "crowdstrike.event.PatternDispositionFlags.SensorOnly" is undefined [13] parsing field value failed: field "crowdstrike.event.LocalPort"''s Go type, string, does not match the expected field type: long [14] parsing field value failed: field "crowdstrike.event.PID"''s Go type, string, does not match the expected field type: long [15] parsing field value failed: field "crowdstrike.event.ProcessEndTime"''s Go type, float64, does not match the expected field type: date [16] parsing field value failed: field "crowdstrike.event.RemotePort"''s Go type, string, does not match the expected field type: long [17] parsing field value failed: field "destination.port"''s Go type, string, does not match the expected field type: long [18] parsing field value failed: field "process.pid"''s Go type, string, does not match the expected field type: long [19] parsing field value failed: field "source.port"''s Go type, string, does not match the expected field type: long
The pipeline needs updated to correct the JSON data types to match the mapping. |
- crowdstrike.event.LocalPort, long - crowdstrike.event.PID, long - crowdstrike.event.ProcessEndTime, delete if 0 - crowdstrike.event.RemotePort, long - destination.port, long - process.pid, long - source.port, long
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
run tests |
andrewstucki
approved these changes
Dec 9, 2020
2 tasks
eyalkraft
pushed a commit
to build-security/integrations
that referenced
this pull request
Mar 30, 2022
* Add system test for CrowdStrike Falcon Add a system test for CrowdStrike Falcon and fix the issues it detected. These were the errors initially detected. crowdstrike/falcon : [0] field "crowdstrike.event.PatternDispositionFlags.Detect" is undefined [1] field "crowdstrike.event.PatternDispositionFlags.InddetMask" is undefined [2] field "crowdstrike.event.PatternDispositionFlags.Indicator" is undefined [3] field "crowdstrike.event.PatternDispositionFlags.KillParent" is undefined [4] field "crowdstrike.event.PatternDispositionFlags.KillProcess" is undefined [5] field "crowdstrike.event.PatternDispositionFlags.KillSubProcess" is undefined [6] field "crowdstrike.event.PatternDispositionFlags.OperationBlocked" is undefined [7] field "crowdstrike.event.PatternDispositionFlags.PolicyDisabled" is undefined [8] field "crowdstrike.event.PatternDispositionFlags.ProcessBlocked" is undefined [9] field "crowdstrike.event.PatternDispositionFlags.QuarantineFile" is undefined [10] field "crowdstrike.event.PatternDispositionFlags.QuarantineMachine" is undefined [11] field "crowdstrike.event.PatternDispositionFlags.Rooting" is undefined [12] field "crowdstrike.event.PatternDispositionFlags.SensorOnly" is undefined [13] parsing field value failed: field "crowdstrike.event.LocalPort"''s Go type, string, does not match the expected field type: long [14] parsing field value failed: field "crowdstrike.event.PID"''s Go type, string, does not match the expected field type: long [15] parsing field value failed: field "crowdstrike.event.ProcessEndTime"''s Go type, float64, does not match the expected field type: date [16] parsing field value failed: field "crowdstrike.event.RemotePort"''s Go type, string, does not match the expected field type: long [17] parsing field value failed: field "destination.port"''s Go type, string, does not match the expected field type: long [18] parsing field value failed: field "process.pid"''s Go type, string, does not match the expected field type: long [19] parsing field value failed: field "source.port"''s Go type, string, does not match the expected field type: long * Fix types for crowdstrike - crowdstrike.event.LocalPort, long - crowdstrike.event.PID, long - crowdstrike.event.ProcessEndTime, delete if 0 - crowdstrike.event.RemotePort, long - destination.port, long - process.pid, long - source.port, long Co-authored-by: Lee E. Hinman <lee.e.hinman@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a system test for CrowdStrike Falcon and fix the issues it detected.
These were the errors initially detected.
Checklist
How to test this PR locally
Related issues