Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add system test for Fortinet Fortimail #438

Merged
merged 3 commits into from
Dec 14, 2020

Conversation

andrewkroh
Copy link
Member

What does this PR do?

This adds system test for Fortinet Fortimail.

It was missing a field entry for ecs.version. And the manifest didn't specify the template_path for log.yml.hbs.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all datasets collect metrics or logs.

Related issues

@elasticmachine
Copy link

elasticmachine commented Dec 3, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #438 updated

  • Start Time: 2020-12-14T15:16:43.268+0000

  • Duration: 30 min 36 sec

Test stats 🧪

Test Results
Failed 0
Passed 133
Skipped 0
Total 133

It was missing a field entry for `ecs.version`. And the manifest didn't specify the `template_path` for log.yml.hbs.
@andrewkroh andrewkroh force-pushed the fortinet-fortimail-sys-test branch from 24a075d to 374d87e Compare December 9, 2020 14:59
@andrewkroh andrewkroh marked this pull request as ready for review December 9, 2020 14:59
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@andrewkroh andrewkroh merged commit 325b6a6 into elastic:master Dec 14, 2020
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
It was missing a field entry for `ecs.version`. And the manifest didn't specify the `template_path` for log.yml.hbs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants