Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sophos xg integration #479

Merged
merged 4 commits into from
Feb 18, 2021
Merged

Add sophos xg integration #479

merged 4 commits into from
Feb 18, 2021

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Dec 22, 2020 •
edited
Loading

What does this PR do?

Adds XG dataset to sophos integrations

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all datasets collect metrics or logs.

Author's Checklist

  • System tests
    • Log input
    • UDP
    • TCP
  • Pipeline tests

Related

@marc-gr marc-gr requested a review from a team December 22, 2020 10:41
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Dec 22, 2020 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #479 updated

  • Start Time: 2021-02-18T15:24:15.883+0000

  • Duration: 16 min 38 sec

  • Commit: 1dac072

Test stats 🧪

Test Results
Failed 0
Passed 301
Skipped 0
Total 301

Trends 🧪

Image of Build Times

Image of Tests

andrewkroh
andrewkroh reviewed Jan 21, 2021
View reviewed changes
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Can you please update this with TCP and UDP syslog tests now that there's a way to add multiple tests. You can see an example in #553. If you have any suggestions for improvements let me know.

@andrewkroh
Copy link
Member

Closes #645

@marc-gr marc-gr requested a review from andrewkroh February 18, 2021 13:21
@marc-gr marc-gr mentioned this pull request Feb 18, 2021
Closed
89 tasks
andrewkroh
andrewkroh reviewed Feb 18, 2021
View reviewed changes
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor comments regarding the config UI. Other than that, looks good to go 👍 .

packages/sophos/_dev/build/docs/README.md Show resolved Hide resolved
packages/sophos/data_stream/xg/agent/stream/log.yml.hbs Show resolved Hide resolved
packages/sophos/data_stream/xg/manifest.yml Show resolved Hide resolved
packages/sophos/data_stream/xg/manifest.yml Outdated Show resolved Hide resolved
packages/sophos/data_stream/xg/manifest.yml Show resolved Hide resolved
@marc-gr marc-gr requested a review from andrewkroh February 18, 2021 15:24
@marc-gr marc-gr merged commit 9fbe88e into elastic:master Feb 18, 2021
@marc-gr marc-gr deleted the sophos branch February 18, 2021 16:24
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
@marc-gr
Add sophos xg integration (elastic#479)
b4123c3 
* Add sophos xg integration

* Add tcp and udp system tests

* Sync with latest changes from beats

* Apply suggestions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marc-gr @elasticmachine @andrewkroh