Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fortinet_fortigate] use YAML literal for script source #6379

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented May 30, 2023

What does this PR do?

All (indented) characters are considered to be content, including white space characters. This causes the source in the YAML to match the source in the ingest processor.

https://yaml.org/spec/1.2.2/#812-literal-style

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file. No user facing changes. Just formatting.
  • I have verified that Kibana version constraints are current according to guidelines.

Related

All (indented) characters are considered to be content, including white space
characters. This causes the source in the YAML to match the source in the
ingest processor.

https://yaml.org/spec/1.2.2/#812-literal-style
@andrewkroh andrewkroh added Team:Security-External Integrations Integration:Fortinet (Deprecated) Use one of the specific fortinet_X labels. labels May 30, 2023
@andrewkroh andrewkroh requested a review from a team as a code owner May 30, 2023 20:26
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-30T20:26:46.833+0000

  • Duration: 16 min 26 sec

Test stats 🧪

Test Results
Failed 0
Passed 9
Skipped 0
Total 9

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (4/4) 💚
Classes 100.0% (4/4) 💚
Methods 100.0% (40/40) 💚 5.882
Lines 91.699% (1171/1277) 👎 -1.804
Conditionals 100.0% (0/0) 💚

@andrewkroh andrewkroh changed the title fortinet_fortigate - use YAML literal for script source [fortinet_fortigate] use YAML literal for script source May 30, 2023
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just confirming here and for the slack and infoblocks changes that the intention is to pick these up in later versions since they do not have changelog entries.

@andrewkroh
Copy link
Member Author

andrewkroh commented May 30, 2023

Yes, that is indeed my indention 🤦 intention.

@andrewkroh andrewkroh merged commit feb1c55 into elastic:main May 30, 2023
agithomas pushed a commit to agithomas/integrations that referenced this pull request Jun 5, 2023
All (indented) characters are considered to be content, including white space
characters. This causes the source in the YAML to match the source in the
ingest processor.

https://yaml.org/spec/1.2.2/#812-literal-style
@andrewkroh andrewkroh added Integration:fortinet_fortigate Fortinet FortiGate Firewall Logs and removed Integration:Fortinet (Deprecated) Use one of the specific fortinet_X labels. labels Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:fortinet_fortigate Fortinet FortiGate Firewall Logs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants