-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cisco] Sync ftd and asa data streams with beats #686
Conversation
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
427c487
to
03d68d8
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
03d68d8
to
18aa439
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, added some small comments in case it was missed or wrong.
@@ -3949,7 +3964,7 @@ | |||
}, | |||
"event": { | |||
"severity": 6, | |||
"ingested": "2021-01-28T23:44:33.971787100Z", | |||
"ingested": "2021-02-15T11:59:05.289395610Z", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the timestamps are updated, are they ignored during golden file checks only, or should they be ignored during the creation of the golden files as well?
@@ -1,7 +1,7 @@ | |||
format_version: 1.0.0 | |||
name: cisco | |||
title: Cisco | |||
version: 0.7.7 | |||
version: 0.7.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw that the Winlogbeat package increase in a minor version, while this increases in a bugfix version, is there any specifications on this?
What does this PR do?
Syncs ftd and asa data streams with latest changes from beats module
Checklist