Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[system] Sync system auth data stream with beats #695

Merged
merged 1 commit into from
Feb 17, 2021

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Feb 16, 2021

What does this PR do?

Syncs system auth data stream with changes made in beats

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Feb 16, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #695 updated

  • Start Time: 2021-02-17T10:01:35.489+0000

  • Duration: 7 min 59 sec

  • Commit: 54bf096

Test stats 🧪

Test Results
Failed 0
Passed 184
Skipped 0
Total 184

Trends 🧪

Image of Build Times

Image of Tests

Copy link
Member

@P1llus P1llus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small comments only. Feel free to ignore them if you don't feel they include in the ECS work, we can work on them afterwards as well!

@@ -14,11 +14,14 @@
}
}
},
"@timestamp": "2020-02-21T21:54:44.000Z",
"@timestamp": "2021-02-21T21:54:44.000Z",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the year missing from these logs?

ecs.version: 1.8.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file sensitive to missing newlines?

@marc-gr marc-gr force-pushed the system_auth-ecs-1.8 branch from eab9ce9 to 54bf096 Compare February 17, 2021 10:01
@marc-gr marc-gr merged commit 88162eb into elastic:master Feb 17, 2021
@marc-gr marc-gr deleted the system_auth-ecs-1.8 branch February 17, 2021 10:11
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants