Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prometheus] Revert prometheus metrics field definition to the format used before introducing metric_type #7324

Conversation

tetianakravchenko
Copy link
Contributor

What does this PR do?

Revert prometheus metrics field definition to the format used before introducing metric_type, as described in this comment. Due to this issue

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

…introducing metric_type

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@elasticmachine
Copy link

elasticmachine commented Aug 9, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-09T12:40:57.550+0000

  • Duration: 18 min 34 sec

Test stats 🧪

Test Results
Failed 0
Passed 9
Skipped 0
Total 9

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 72.727% (8/11) 👎 -26.81
Lines 100.0% (0/0) 💚 14.71
Conditionals 100.0% (0/0) 💚

@tetianakravchenko tetianakravchenko merged commit 4786ff9 into elastic:main Aug 9, 2023
1 check passed
@tetianakravchenko tetianakravchenko deleted the prometheus_revert_metrics_definition branch August 9, 2023 13:47
@elasticmachine
Copy link

Package prometheus - 1.7.0 containing this change is available at https://epr.elastic.co/search?package=prometheus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants