Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Zookeeper] Add metric type mapping for server datastream #7885

Merged
merged 7 commits into from
Sep 26, 2023
Merged

[Zookeeper] Add metric type mapping for server datastream #7885

merged 7 commits into from
Sep 26, 2023

Conversation

agithomas
Copy link
Contributor

@agithomas agithomas commented Sep 20, 2023 •
edited
Loading

What does this PR do?

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

elastic/beats#8938
#7752

@agithomas agithomas force-pushed the issue-7752-server-metric-type branch from 573a4ea to 7903c32 Compare September 20, 2023 11:55
@agithomas agithomas changed the title Issue 7752 server metric type [Zookeeper] Add metric type mapping for server datastream Sep 20, 2023
@elasticmachine
Copy link

elasticmachine commented Sep 20, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-26T07:50:17.392+0000

  • Duration: 13 min 8 sec

Test stats 🧪

Test Results
Failed 0
Passed 7
Skipped 0
Total 7

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Sep 20, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 66.667% (6/9) 👍
Lines 100.0% (0/0) 💚
Conditionals 100.0% (0/0) 💚

@agithomas agithomas marked this pull request as ready for review September 20, 2023 13:33
@agithomas agithomas requested a review from a team as a code owner September 20, 2023 13:33
@agithomas agithomas mentioned this pull request Sep 21, 2023
Closed
11 tasks
ritalwar
ritalwar approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@ritalwar ritalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

lalit-satapathy
lalit-satapathy approved these changes Sep 26, 2023
View reviewed changes
Copy link
Collaborator

@lalit-satapathy lalit-satapathy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agithomas agithomas merged commit e39a2f3 into elastic:main Sep 26, 2023
1 check passed
@elasticmachine
Copy link

Package zookeeper - 1.8.2 containing this change is available at https://epr.elastic.co/search?package=zookeeper

@andrewkroh andrewkroh added the Integration:zookeeper ZooKeeper Metrics label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritalwar ritalwar ritalwar approved these changes

@lalit-satapathy lalit-satapathy lalit-satapathy approved these changes

Assignees
No one assigned
Labels
Integration:zookeeper ZooKeeper Metrics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@agithomas @elasticmachine @lalit-satapathy @ritalwar @andrewkroh