Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ECS] Cleaning up incorrect invalid ECS field usages at root-level #7965

Merged
merged 9 commits into from
Sep 26, 2023
Merged

[ECS] Cleaning up incorrect invalid ECS field usages at root-level #7965

merged 9 commits into from
Sep 26, 2023

Conversation

kgeller
Copy link
Contributor

@kgeller kgeller commented Sep 25, 2023 •
edited
Loading

What does this PR do?

Removing the unused and incorrect ECS field usages at the root-level for the following packages:

  • azure_frontdoor
  • carbonblack_edr
  • cisco_meraki
  • juniper_srx
  • netflow

Note: this is purely a docs change

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@kgeller kgeller added bug Something isn't working, use only for issues Team:Security-External Integrations docs Integration:azure_frontdoor Azure Frontdoor labels Sep 25, 2023
@kgeller kgeller self-assigned this Sep 25, 2023
@kgeller kgeller mentioned this pull request Sep 25, 2023
Closed
@kgeller kgeller changed the title [ECS][azure_frontdoor] Cleaning up incorrect invalid ECS field usages at root-level [ECS] Cleaning up incorrect invalid ECS field usages at root-level Sep 25, 2023
@elasticmachine
Copy link

elasticmachine commented Sep 25, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-26T17:50:17.863+0000

  • Duration: 18 min 17 sec

Test stats 🧪

Test Results
Failed 0
Passed 64
Skipped 0
Total 64

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Sep 25, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (7/7) 💚
Files 100.0% (21/21) 💚
Classes 100.0% (21/21) 💚
Methods 97.688% (169/173) 👍 9.809
Lines 80.549% (4195/5208) 👎 -14.742
Conditionals 100.0% (0/0) 💚

@kgeller kgeller added the Integration:carbonblack_edr VMware Carbon Black EDR label Sep 25, 2023
@kgeller kgeller marked this pull request as ready for review September 25, 2023 17:43
@kgeller kgeller requested a review from a team as a code owner September 25, 2023 17:43
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

taylor-swanson
taylor-swanson approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@taylor-swanson taylor-swanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgeller kgeller marked this pull request as draft September 25, 2023 18:09
@kgeller kgeller removed the Integration:juniper_srx Juniper SRX label Sep 26, 2023
@kgeller kgeller added the Integration:juniper_srx Juniper SRX label Sep 26, 2023
@kgeller kgeller added the Integration:netflow NetFlow Records label Sep 26, 2023
@kgeller kgeller marked this pull request as ready for review September 26, 2023 18:34
@kgeller kgeller merged commit 9a14e77 into elastic:main Sep 26, 2023
1 check passed
@kgeller kgeller deleted the 7808-azurefrontdoor branch September 26, 2023 19:30
@kgeller kgeller restored the 7808-azurefrontdoor branch September 26, 2023 19:30
@kgeller kgeller deleted the 7808-azurefrontdoor branch September 26, 2023 19:30
@kgeller kgeller restored the 7808-azurefrontdoor branch September 26, 2023 19:30
@elasticmachine
Copy link

Package azure_frontdoor - 1.3.2 containing this change is available at https://epr.elastic.co/search?package=azure_frontdoor

@elasticmachine
Copy link

Package carbonblack_edr - 1.14.1 containing this change is available at https://epr.elastic.co/search?package=carbonblack_edr

@elasticmachine
Copy link

Package cisco_meraki - 1.15.1 containing this change is available at https://epr.elastic.co/search?package=cisco_meraki

@elasticmachine
Copy link

Package juniper_srx - 1.16.1 containing this change is available at https://epr.elastic.co/search?package=juniper_srx

@elasticmachine
Copy link

Package netflow - 2.15.1 containing this change is available at https://epr.elastic.co/search?package=netflow

@kgeller kgeller mentioned this pull request Sep 28, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taylor-swanson taylor-swanson taylor-swanson approved these changes

Assignees

@kgeller kgeller

Labels
bug Something isn't working, use only for issues docs Integration:azure_frontdoor Azure Frontdoor Integration:carbonblack_edr VMware Carbon Black EDR Integration:cisco_meraki Cisco Meraki Integration:juniper_srx Juniper SRX Integration:netflow NetFlow Records
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kgeller @elasticmachine @taylor-swanson